feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Remove enabledChanged emissions

Browse Source 
... from *RunConfiguration::setUpdater implementations.

The RunConfiguration::update() emits it unconditionally nowadays.

Change-Id: I0a67b760ea611026bd2357f59090166be8e0d6b3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-12-19 14:13:33 +01:00
parent 445a09b17c
commit 230741f5a9
4 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/baremetal/baremetalrunconfiguration.cpp
View File

@@ -53,7 +53,6 @@ BareMetalRunConfiguration::BareMetalRunConfiguration(Target *target, Core::Id id
setUpdater([this, exeAspect] { setUpdater([this, exeAspect] {
const BuildTargetInfo bti = buildTargetInfo(); const BuildTargetInfo bti = buildTargetInfo();
exeAspect->setExecutable(bti.targetFilePath); exeAspect->setExecutable(bti.targetFilePath);
emit enabledChanged();
}); });
connect(target, &Target::buildSystemUpdated, this, &RunConfiguration::update); connect(target, &Target::buildSystemUpdated, this, &RunConfiguration::update);

2
src/plugins/projectexplorer/desktoprunconfiguration.cpp
View File

@@ -124,8 +124,6 @@ void DesktopRunConfiguration::updateTargetInformation()
aspect<WorkingDirectoryAspect>()->setDefaultWorkingDirectory(defaultWorkingDir); aspect<WorkingDirectoryAspect>()->setDefaultWorkingDirectory(defaultWorkingDir);
} }
emit enabledChanged();
} else if (m_kind == CMake) { } else if (m_kind == CMake) {
aspect<ExecutableAspect>()->setExecutable(bti.targetFilePath); aspect<ExecutableAspect>()->setExecutable(bti.targetFilePath);

1
src/plugins/qnx/qnxrunconfiguration.cpp
View File

@@ -76,7 +76,6 @@ QnxRunConfiguration::QnxRunConfiguration(Target *target, Core::Id id)
.deployableForLocalFile(localExecutable); .deployableForLocalFile(localExecutable);
exeAspect->setExecutable(FilePath::fromString(depFile.remoteFilePath())); exeAspect->setExecutable(FilePath::fromString(depFile.remoteFilePath()));
symbolsAspect->setFilePath(localExecutable); symbolsAspect->setFilePath(localExecutable);
emit enabledChanged();
}); });
connect(target, &Target::buildSystemUpdated, this, &RunConfiguration::update); connect(target, &Target::buildSystemUpdated, this, &RunConfiguration::update);

2
src/plugins/remotelinux/remotelinuxrunconfiguration.cpp
View File

@@ -76,8 +76,6 @@ RemoteLinuxRunConfiguration::RemoteLinuxRunConfiguration(Target *target, Core::I
exeAspect->setExecutable(FilePath::fromString(depFile.remoteFilePath())); exeAspect->setExecutable(FilePath::fromString(depFile.remoteFilePath()));
symbolsAspect->setFilePath(localExecutable); symbolsAspect->setFilePath(localExecutable);
emit enabledChanged();
}); });
connect(target, &Target::buildSystemUpdated, this, &RunConfiguration::update); connect(target, &Target::buildSystemUpdated, this, &RunConfiguration::update);