DeviceSupport: Add canAutoDetectPorts() method

Use case: Devices such as Desktop device can
automatically choose an available port.

Change-Id: I6515425da3ae861b62d103885e2fde0e542d21d0
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>

src/plugins/debugger/debuggerrunconfigurationaspect.cpp

@@ -288,7 +288,7 @@ bool DebuggerRunConfigurationAspect::isQmlDebuggingSpinboxSuppressed() const
     ProjectExplorer::IDevice::ConstPtr dev = ProjectExplorer::DeviceKitInformation::device(k);
     if (dev.isNull())
         return false;
-    return dev->portsGatheringMethod().isNull(); // We know the free ports...
+    return dev->canAutoDetectPorts();
 }
 
 QString DebuggerRunConfigurationAspect::displayName() const

src/plugins/projectexplorer/devicesupport/desktopdevice.cpp

@@ -90,6 +90,11 @@ void DesktopDevice::executeAction(Core::Id actionId, QWidget *parent) const
     Q_UNUSED(parent);
 }
 
+bool DesktopDevice::canAutoDetectPorts() const
+{
+    return true;
+}
+
 bool DesktopDevice::canCreateProcessModel() const
 {
     return true;

src/plugins/projectexplorer/devicesupport/desktopdevice.h

@@ -50,6 +50,7 @@ public:
     QList<Core::Id> actionIds() const;
     QString displayNameForActionId(Core::Id actionId) const;
     void executeAction(Core::Id actionId, QWidget *parent = 0) const;
+    bool canAutoDetectPorts() const;
     bool canCreateProcessModel() const;
     DeviceProcessList *createProcessListModel(QObject *parent) const;
 

src/plugins/projectexplorer/devicesupport/idevice.h

@@ -112,6 +112,9 @@ public:
     virtual void executeAction(Core::Id actionId, QWidget *parent = 0) const = 0;
 
     virtual DeviceProcessSupport::Ptr processSupport() const;
+    // Devices that can auto detect ports need not return a ports gathering method. Such devices can
+    // obtain a free port on demand. eg: Desktop device.
+    virtual bool canAutoDetectPorts() const { return false; }
     virtual PortsGatheringMethod::Ptr portsGatheringMethod() const;
     virtual bool canCreateProcessModel() const { return false; }
     virtual DeviceProcessList *createProcessListModel(QObject *parent = 0) const;

src/plugins/remotelinux/linuxdevice.cpp

@@ -249,6 +249,11 @@ DeviceProcessSupport::Ptr LinuxDevice::processSupport() const
     return DeviceProcessSupport::Ptr(new LinuxDeviceProcessSupport);
 }
 
+bool LinuxDevice::canAutoDetectPorts() const
+{
+    return true;
+}
+
 PortsGatheringMethod::Ptr LinuxDevice::portsGatheringMethod() const
 {
     return LinuxPortsGatheringMethod::Ptr(new LinuxPortsGatheringMethod);

src/plugins/remotelinux/linuxdevice.h

@@ -69,6 +69,7 @@ public:
     ProjectExplorer::IDevice::Ptr clone() const;
 
     ProjectExplorer::DeviceProcessSupport::Ptr processSupport() const;
+    bool canAutoDetectPorts() const;
     ProjectExplorer::PortsGatheringMethod::Ptr portsGatheringMethod() const;
     bool canCreateProcessModel() const { return true; }
     ProjectExplorer::DeviceProcessList *createProcessListModel(QObject *parent) const;