feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Make DeployConfiguration final

Browse Source 
There are no derived classes anymore.

It turns out that the isEnabled() and disabledReason() functions
are unused. Remove them.

Change-Id: I0e79729e87cb68d938115e704fb8e45c24ba1013
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-01-18 15:27:05 +01:00
parent bb72406dad
commit 23c578c478
2 changed files with 2 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/projectexplorer/deployconfiguration.cpp
View File

@@ -83,16 +83,6 @@ QVariantMap DeployConfiguration::toMap() const
return map; return map;
} }
bool DeployConfiguration::isEnabled() const
{
return false;
}
QString DeployConfiguration::disabledReason() const
{
return QString();
}
bool DeployConfiguration::fromMap(const QVariantMap &map) bool DeployConfiguration::fromMap(const QVariantMap &map)
{ {
if (!ProjectConfiguration::fromMap(map)) if (!ProjectConfiguration::fromMap(map))

10
src/plugins/projectexplorer/deployconfiguration.h
View File

@@ -37,11 +37,11 @@ class Target;
class DeployConfigurationFactory; class DeployConfigurationFactory;
class NamedWidget; class NamedWidget;
class PROJECTEXPLORER_EXPORT DeployConfiguration : public ProjectConfiguration class PROJECTEXPLORER_EXPORT DeployConfiguration final : public ProjectConfiguration
{ {
Q_OBJECT Q_OBJECT
protected: private:
friend class DeployConfigurationFactory; friend class DeployConfigurationFactory;
explicit DeployConfiguration(Target *target, Core::Id id); explicit DeployConfiguration(Target *target, Core::Id id);
@@ -56,17 +56,11 @@ public:
bool fromMap(const QVariantMap &map) override; bool fromMap(const QVariantMap &map) override;
QVariantMap toMap() const override; QVariantMap toMap() const override;
virtual bool isEnabled() const;
virtual QString disabledReason() const;
Target *target() const; Target *target() const;
Project *project() const override; Project *project() const override;
bool isActive() const override; bool isActive() const override;
signals:
void enabledChanged();
private: private:
BuildStepList m_stepList; BuildStepList m_stepList;
std::function<NamedWidget *(Target *)> m_configWidgetCreator; std::function<NamedWidget *(Target *)> m_configWidgetCreator;