feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Modeling: Avoid undefined behavior

Browse Source 
With vector based QStringList there's no sequence point between
decrement and assignment.

Drop the assignment, it's unneeded anyway.

Change-Id: Ib88008ec4e3ddada3807ca41fbcc0c981cef5fe3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2020-04-29 09:50:12 +02:00
parent f6042b257d
commit 26b409c610
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libs/modelinglib/qmt/controller/namecontroller.cpp
View File

@@ -138,7 +138,7 @@ QStringList NameController::buildElementsPath(const QString &filePath, bool igno
QStringList split = filePath.split("/"); QStringList split = filePath.split("/");
QStringList::const_iterator splitEnd = split.constEnd(); QStringList::const_iterator splitEnd = split.constEnd();
if (ignoreLastFilePathPart || split.last().isEmpty()) if (ignoreLastFilePathPart || split.last().isEmpty())
splitEnd = --splitEnd; --splitEnd;
for (auto it = split.constBegin(); it != splitEnd; ++it) { for (auto it = split.constBegin(); it != splitEnd; ++it) {
QString packageName = qmt::NameController::convertFileNameToElementName(*it); QString packageName = qmt::NameController::convertFileNameToElementName(*it);
relativeElements.append(packageName); relativeElements.append(packageName);