Core: Turn LocatorFilterEntry ofn ILocatorFilter::accept to const &

In ILocatorFilter::accept and all the overrides. Change-Id: I27cd6babb66d91aad57e85572a1cdc77aef4fd79 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-10 17:16:04 +01:00
parent 93fc6b5c3c
commit 26bf18e1fe
44 changed files with 50 additions and 50 deletions
--- a/src/plugins/bookmarks/bookmarkfilter.cpp
+++ b/src/plugins/bookmarks/bookmarkfilter.cpp
@@ -124,7 +124,7 @@ QList<LocatorFilterEntry> BookmarkFilter::matchesFor(QFutureInterface<LocatorFil
    return m_results;
 }

-void BookmarkFilter::accept(LocatorFilterEntry selection, QString *newText,
+void BookmarkFilter::accept(const LocatorFilterEntry &selection, QString *newText,
                            int *selectionStart, int *selectionLength) const
 {
    Q_UNUSED(newText)
--- a/src/plugins/bookmarks/bookmarkfilter.h
+++ b/src/plugins/bookmarks/bookmarkfilter.h
@@ -40,7 +40,7 @@ public:
    void prepareSearch(const QString &entry) override;
    QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                               const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection, QString *newText,
+    void accept(const Core::LocatorFilterEntry &selection, QString *newText,
                int *selectionStart, int *selectionLength) const override;

 private:
--- a/src/plugins/clangcodemodel/clangcurrentdocumentfilter.cpp
+++ b/src/plugins/clangcodemodel/clangcurrentdocumentfilter.cpp
@@ -135,7 +135,7 @@ QList<Core::LocatorFilterEntry> ClangCurrentDocumentFilter::matchesFor(
    return goodEntries;
 }

-void ClangCurrentDocumentFilter::accept(Core::LocatorFilterEntry selection,
+void ClangCurrentDocumentFilter::accept(const Core::LocatorFilterEntry &selection,
            QString *, int *, int *) const
 {
    if (!m_currentEditor)
--- a/src/plugins/clangcodemodel/clangcurrentdocumentfilter.h
+++ b/src/plugins/clangcodemodel/clangcurrentdocumentfilter.h
@@ -42,7 +42,7 @@ public:
    void prepareSearch(const QString &entry) override;
    QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                               const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                QString *newText, int *selectionStart, int *selectionLength) const override;

 private:
--- a/src/plugins/clangcodemodel/clangdlocatorfilters.cpp
+++ b/src/plugins/clangcodemodel/clangdlocatorfilters.cpp
@@ -198,7 +198,7 @@ QList<Core::LocatorFilterEntry> ClangGlobalSymbolFilter::matchesFor(
    return matches;
 }

-void ClangGlobalSymbolFilter::accept(Core::LocatorFilterEntry selection, QString *newText,
+void ClangGlobalSymbolFilter::accept(const Core::LocatorFilterEntry &selection, QString *newText,
                                     int *selectionStart, int *selectionLength) const
 {
    if (qvariant_cast<CppEditor::IndexItem::Ptr>(selection.internalData))
@@ -318,7 +318,7 @@ QList<Core::LocatorFilterEntry> ClangdCurrentDocumentFilter::matchesFor(
    return d->activeFilter->matchesFor(future, entry);
 }

-void ClangdCurrentDocumentFilter::accept(Core::LocatorFilterEntry selection, QString *newText,
+void ClangdCurrentDocumentFilter::accept(const Core::LocatorFilterEntry &selection, QString *newText,
                                         int *selectionStart, int *selectionLength) const
 {
    QTC_ASSERT(d->activeFilter, return);
--- a/src/plugins/clangcodemodel/clangdlocatorfilters.h
+++ b/src/plugins/clangcodemodel/clangdlocatorfilters.h
@@ -41,7 +41,7 @@ private:
    void prepareSearch(const QString &entry) override;
    QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                               const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection, QString *newText,
+    void accept(const Core::LocatorFilterEntry &selection, QString *newText,
                int *selectionStart, int *selectionLength) const override;

    Core::ILocatorFilter * const m_cppFilter;
@@ -70,7 +70,7 @@ private:
    void prepareSearch(const QString &entry) override;
    QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                               const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection, QString *newText,
+    void accept(const Core::LocatorFilterEntry &selection, QString *newText,
                int *selectionStart, int *selectionLength) const override;

    class Private;
--- a/src/plugins/cmakeprojectmanager/cmakelocatorfilter.cpp
+++ b/src/plugins/cmakeprojectmanager/cmakelocatorfilter.cpp
@@ -121,7 +121,7 @@ BuildCMakeTargetLocatorFilter::BuildCMakeTargetLocatorFilter()
    setPriority(High);
 }

-void BuildCMakeTargetLocatorFilter::accept(Core::LocatorFilterEntry selection,
+void BuildCMakeTargetLocatorFilter::accept(const Core::LocatorFilterEntry &selection,
                                           QString *newText,
                                           int *selectionStart,
                                           int *selectionLength) const
@@ -171,7 +171,7 @@ OpenCMakeTargetLocatorFilter::OpenCMakeTargetLocatorFilter()
    setPriority(Medium);
 }

-void OpenCMakeTargetLocatorFilter::accept(Core::LocatorFilterEntry selection,
+void OpenCMakeTargetLocatorFilter::accept(const Core::LocatorFilterEntry &selection,
                                          QString *newText,
                                          int *selectionStart,
                                          int *selectionLength) const
--- a/src/plugins/cmakeprojectmanager/cmakelocatorfilter.h
+++ b/src/plugins/cmakeprojectmanager/cmakelocatorfilter.h
@@ -54,7 +54,7 @@ class BuildCMakeTargetLocatorFilter : CMakeTargetLocatorFilter
 public:
    BuildCMakeTargetLocatorFilter();

-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                QString *newText,
                int *selectionStart,
                int *selectionLength) const final;
@@ -67,7 +67,7 @@ class OpenCMakeTargetLocatorFilter : CMakeTargetLocatorFilter
 public:
    OpenCMakeTargetLocatorFilter();

-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                QString *newText,
                int *selectionStart,
                int *selectionLength) const final;
--- a/src/plugins/coreplugin/locator/basefilefilter.cpp
+++ b/src/plugins/coreplugin/locator/basefilefilter.cpp
@@ -218,7 +218,7 @@ QList<LocatorFilterEntry> BaseFileFilter::matchesFor(QFutureInterface<LocatorFil
 /*!
    \reimp
 */
-void BaseFileFilter::accept(LocatorFilterEntry selection,
+void BaseFileFilter::accept(const LocatorFilterEntry &selection,
                            QString *newText, int *selectionStart, int *selectionLength) const
 {
    Q_UNUSED(newText)
--- a/src/plugins/coreplugin/locator/basefilefilter.h
+++ b/src/plugins/coreplugin/locator/basefilefilter.h
@@ -68,7 +68,7 @@ public:
    void prepareSearch(const QString &entry) override;
    QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                         const QString &entry) override;
-    void accept(LocatorFilterEntry selection,
+    void accept(const LocatorFilterEntry &selection,
                QString *newText, int *selectionStart, int *selectionLength) const override;
    static void openEditorAt(const LocatorFilterEntry &selection);

--- a/src/plugins/coreplugin/locator/commandlocator.cpp
+++ b/src/plugins/coreplugin/locator/commandlocator.cpp
@@ -112,7 +112,7 @@ QList<LocatorFilterEntry> CommandLocator::matchesFor(QFutureInterface<LocatorFil
    return betterEntries;
 }

-void CommandLocator::accept(LocatorFilterEntry entry,
+void CommandLocator::accept(const LocatorFilterEntry &entry,
                            QString *newText, int *selectionStart, int *selectionLength) const
 {
    Q_UNUSED(newText)
--- a/src/plugins/coreplugin/locator/commandlocator.h
+++ b/src/plugins/coreplugin/locator/commandlocator.h
@@ -48,7 +48,7 @@ public:
    void prepareSearch(const QString &entry) override;
    QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                         const QString &entry) override;
-    void accept(LocatorFilterEntry selection,
+    void accept(const LocatorFilterEntry &selection,
                QString *newText, int *selectionStart, int *selectionLength) const override;

 private:
--- a/src/plugins/coreplugin/locator/executefilter.cpp
+++ b/src/plugins/coreplugin/locator/executefilter.cpp
@@ -80,7 +80,7 @@ QList<LocatorFilterEntry> ExecuteFilter::matchesFor(QFutureInterface<LocatorFilt
    return value;
 }

-void ExecuteFilter::accept(LocatorFilterEntry selection,
+void ExecuteFilter::accept(const LocatorFilterEntry &selection,
                           QString *newText, int *selectionStart, int *selectionLength) const
 {
    Q_UNUSED(newText)
--- a/src/plugins/coreplugin/locator/executefilter.h
+++ b/src/plugins/coreplugin/locator/executefilter.h
@@ -51,7 +51,7 @@ public:
    ~ExecuteFilter() override;
    QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                         const QString &entry) override;
-    void accept(LocatorFilterEntry selection,
+    void accept(const LocatorFilterEntry &selection,
                QString *newText, int *selectionStart, int *selectionLength) const override;

 private:
--- a/src/plugins/coreplugin/locator/externaltoolsfilter.cpp
+++ b/src/plugins/coreplugin/locator/externaltoolsfilter.cpp
@@ -49,7 +49,7 @@ QList<LocatorFilterEntry> ExternalToolsFilter::matchesFor(QFutureInterface<Locat
    return m_results;
 }

-void ExternalToolsFilter::accept(LocatorFilterEntry selection,
+void ExternalToolsFilter::accept(const LocatorFilterEntry &selection,
                                 QString *newText, int *selectionStart, int *selectionLength) const
 {
    Q_UNUSED(newText)
--- a/src/plugins/coreplugin/locator/externaltoolsfilter.h
+++ b/src/plugins/coreplugin/locator/externaltoolsfilter.h
@@ -38,7 +38,7 @@ public:

    QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                         const QString &entry) override;
-    void accept(LocatorFilterEntry selection,
+    void accept(const LocatorFilterEntry &selection,
                QString *newText, int *selectionStart, int *selectionLength) const override;
    void prepareSearch(const QString &entry) override;

--- a/src/plugins/coreplugin/locator/filesystemfilter.cpp
+++ b/src/plugins/coreplugin/locator/filesystemfilter.cpp
@@ -169,7 +169,7 @@ QList<LocatorFilterEntry> FileSystemFilter::matchesFor(QFutureInterface<LocatorF

 const char kAlwaysCreate[] = "Locator/FileSystemFilter/AlwaysCreate";

-void FileSystemFilter::accept(LocatorFilterEntry selection,
+void FileSystemFilter::accept(const LocatorFilterEntry &selection,
                              QString *newText,
                              int *selectionStart,
                              int *selectionLength) const
--- a/src/plugins/coreplugin/locator/filesystemfilter.h
+++ b/src/plugins/coreplugin/locator/filesystemfilter.h
@@ -45,7 +45,7 @@ public:
    void prepareSearch(const QString &entry) override;
    QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                         const QString &entry) override;
-    void accept(LocatorFilterEntry selection,
+    void accept(const LocatorFilterEntry &selection,
                QString *newText, int *selectionStart, int *selectionLength) const override;
    void restoreState(const QByteArray &state) override;
    bool openConfigDialog(QWidget *parent, bool &needsRefresh) override;
--- a/src/plugins/coreplugin/locator/ilocatorfilter.cpp
+++ b/src/plugins/coreplugin/locator/ilocatorfilter.cpp
@@ -595,7 +595,7 @@ bool ILocatorFilter::isOldSetting(const QByteArray &state)
 */

 /*!
-    \fn void Core::ILocatorFilter::accept(Core::LocatorFilterEntry selection, QString *newText, int *selectionStart, int *selectionLength) const
+    \fn void Core::ILocatorFilter::accept(Core::const LocatorFilterEntry &selection, QString *newText, int *selectionStart, int *selectionLength) const

    Called with the entry specified by \a selection when the user activates it
    in the result list.
--- a/src/plugins/coreplugin/locator/ilocatorfilter.h
+++ b/src/plugins/coreplugin/locator/ilocatorfilter.h
@@ -143,7 +143,7 @@ public:

    virtual QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future, const QString &entry) = 0;

-    virtual void accept(LocatorFilterEntry selection,
+    virtual void accept(const LocatorFilterEntry &selection,
                        QString *newText, int *selectionStart, int *selectionLength) const = 0;

    virtual void refresh(QFutureInterface<void> &future) { Q_UNUSED(future) };
--- a/src/plugins/coreplugin/locator/javascriptfilter.cpp
+++ b/src/plugins/coreplugin/locator/javascriptfilter.cpp
@@ -89,7 +89,7 @@ QList<LocatorFilterEntry> JavaScriptFilter::matchesFor(
    return entries;
 }

-void JavaScriptFilter::accept(Core::LocatorFilterEntry selection, QString *newText,
+void JavaScriptFilter::accept(const LocatorFilterEntry &selection, QString *newText,
                              int *selectionStart, int *selectionLength) const
 {
    Q_UNUSED(newText)
--- a/src/plugins/coreplugin/locator/javascriptfilter.h
+++ b/src/plugins/coreplugin/locator/javascriptfilter.h
@@ -49,7 +49,7 @@ public:
    void prepareSearch(const QString &entry) override;
    QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                               const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection, QString *newText,
+    void accept(const Core::LocatorFilterEntry &selection, QString *newText,
                int *selectionStart, int *selectionLength) const override;

 private:
--- a/src/plugins/coreplugin/locator/locatorfiltersfilter.cpp
+++ b/src/plugins/coreplugin/locator/locatorfiltersfilter.cpp
@@ -89,7 +89,7 @@ QList<LocatorFilterEntry> LocatorFiltersFilter::matchesFor(QFutureInterface<Loca
    return entries;
 }

-void LocatorFiltersFilter::accept(LocatorFilterEntry selection,
+void LocatorFiltersFilter::accept(const LocatorFilterEntry &selection,
                                  QString *newText, int *selectionStart, int *selectionLength) const
 {
    Q_UNUSED(selectionLength)
--- a/src/plugins/coreplugin/locator/locatorfiltersfilter.h
+++ b/src/plugins/coreplugin/locator/locatorfiltersfilter.h
@@ -49,7 +49,7 @@ public:
    void prepareSearch(const QString &entry) override;
    QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                         const QString &entry) override;
-    void accept(LocatorFilterEntry selection,
+    void accept(const LocatorFilterEntry &selection,
                QString *newText, int *selectionStart, int *selectionLength) const override;

 private:
--- a/src/plugins/coreplugin/locator/opendocumentsfilter.cpp
+++ b/src/plugins/coreplugin/locator/opendocumentsfilter.cpp
@@ -120,7 +120,7 @@ void OpenDocumentsFilter::refresh(QFutureInterface<void> &future)
    QMetaObject::invokeMethod(this, &OpenDocumentsFilter::refreshInternally, Qt::QueuedConnection);
 }

-void OpenDocumentsFilter::accept(LocatorFilterEntry selection,
+void OpenDocumentsFilter::accept(const LocatorFilterEntry &selection,
                                 QString *newText, int *selectionStart, int *selectionLength) const
 {
    Q_UNUSED(newText)
--- a/src/plugins/coreplugin/locator/opendocumentsfilter.h
+++ b/src/plugins/coreplugin/locator/opendocumentsfilter.h
@@ -45,7 +45,7 @@ public:
    OpenDocumentsFilter();
    QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                         const QString &entry) override;
-    void accept(LocatorFilterEntry selection,
+    void accept(const LocatorFilterEntry &selection,
                QString *newText, int *selectionStart, int *selectionLength) const override;
    void refresh(QFutureInterface<void> &future) override;

--- a/src/plugins/coreplugin/locator/urllocatorfilter.cpp
+++ b/src/plugins/coreplugin/locator/urllocatorfilter.cpp
@@ -162,7 +162,7 @@ QList<Core::LocatorFilterEntry> UrlLocatorFilter::matchesFor(
    return entries;
 }

-void UrlLocatorFilter::accept(Core::LocatorFilterEntry selection,
+void UrlLocatorFilter::accept(const Core::LocatorFilterEntry &selection,
                              QString *newText,
                              int *selectionStart,
                              int *selectionLength) const
--- a/src/plugins/coreplugin/locator/urllocatorfilter.h
+++ b/src/plugins/coreplugin/locator/urllocatorfilter.h
@@ -46,7 +46,7 @@ public:
    // ILocatorFilter
    QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                               const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                QString *newText, int *selectionStart, int *selectionLength) const override;
    void restoreState(const QByteArray &state) override;
    bool openConfigDialog(QWidget *parent, bool &needsRefresh) override;
--- a/src/plugins/coreplugin/menubarfilter.cpp
+++ b/src/plugins/coreplugin/menubarfilter.cpp
@@ -79,7 +79,7 @@ QList<LocatorFilterEntry> MenuBarFilter::matchesFor(QFutureInterface<LocatorFilt
    return std::move(m_entries);
 }

-void MenuBarFilter::accept(LocatorFilterEntry selection, QString *newText,
+void MenuBarFilter::accept(const LocatorFilterEntry &selection, QString *newText,
                           int *selectionStart, int *selectionLength) const
 {
    Q_UNUSED(newText)
--- a/src/plugins/coreplugin/menubarfilter.h
+++ b/src/plugins/coreplugin/menubarfilter.h
@@ -47,7 +47,7 @@ public:

    QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                         const QString &entry) override;
-    void accept(LocatorFilterEntry selection, QString *newText,
+    void accept(const LocatorFilterEntry &selection, QString *newText,
                int *selectionStart, int *selectionLength) const override;
    void prepareSearch(const QString &entry) override;

--- a/src/plugins/cppeditor/cppcurrentdocumentfilter.cpp
+++ b/src/plugins/cppeditor/cppcurrentdocumentfilter.cpp
@@ -117,7 +117,7 @@ QList<Core::LocatorFilterEntry> CppCurrentDocumentFilter::matchesFor(
    return betterEntries;
 }

-void CppCurrentDocumentFilter::accept(Core::LocatorFilterEntry selection,
+void CppCurrentDocumentFilter::accept(const Core::LocatorFilterEntry &selection,
                                      QString *newText, int *selectionStart,
                                      int *selectionLength) const
 {
--- a/src/plugins/cppeditor/cppcurrentdocumentfilter.h
+++ b/src/plugins/cppeditor/cppcurrentdocumentfilter.h
@@ -47,7 +47,7 @@ public:

    QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                               const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                QString *newText, int *selectionStart, int *selectionLength) const override;

 private:
--- a/src/plugins/cppeditor/cpplocatorfilter.cpp
+++ b/src/plugins/cppeditor/cpplocatorfilter.cpp
@@ -136,7 +136,7 @@ QList<Core::LocatorFilterEntry> CppLocatorFilter::matchesFor(
    return std::accumulate(std::begin(entries), std::end(entries), QList<Core::LocatorFilterEntry>());
 }

-void CppLocatorFilter::accept(Core::LocatorFilterEntry selection,
+void CppLocatorFilter::accept(const Core::LocatorFilterEntry &selection,
                              QString *newText, int *selectionStart, int *selectionLength) const
 {
    Q_UNUSED(newText)
--- a/src/plugins/cppeditor/cpplocatorfilter.h
+++ b/src/plugins/cppeditor/cpplocatorfilter.h
@@ -43,7 +43,7 @@ public:

    QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                               const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                QString *newText, int *selectionStart, int *selectionLength) const override;

 protected:
--- a/src/plugins/help/helpindexfilter.cpp
+++ b/src/plugins/help/helpindexfilter.cpp
@@ -197,7 +197,7 @@ QList<LocatorFilterEntry> HelpIndexFilter::matchesFor(QFutureInterface<LocatorFi

 #endif

-void HelpIndexFilter::accept(LocatorFilterEntry selection,
+void HelpIndexFilter::accept(const LocatorFilterEntry &selection,
                             QString *newText, int *selectionStart, int *selectionLength) const
 {
    Q_UNUSED(newText)
--- a/src/plugins/help/helpindexfilter.h
+++ b/src/plugins/help/helpindexfilter.h
@@ -48,7 +48,7 @@ public:
    // ILocatorFilter
    QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                               const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                QString *newText, int *selectionStart, int *selectionLength) const override;
    void refresh(QFutureInterface<void> &future) override;

--- a/src/plugins/languageclient/locatorfilter.cpp
+++ b/src/plugins/languageclient/locatorfilter.cpp
@@ -218,7 +218,7 @@ QList<Core::LocatorFilterEntry> DocumentLocatorFilter::matchesFor(
    return {};
 }

-void DocumentLocatorFilter::accept(Core::LocatorFilterEntry selection,
+void DocumentLocatorFilter::accept(const Core::LocatorFilterEntry &selection,
                                   QString * /*newText*/,
                                   int * /*selectionStart*/,
                                   int * /*selectionLength*/) const
@@ -325,7 +325,7 @@ QList<Core::LocatorFilterEntry> WorkspaceLocatorFilter::matchesFor(
        .toList();
 }

-void WorkspaceLocatorFilter::accept(Core::LocatorFilterEntry selection,
+void WorkspaceLocatorFilter::accept(const Core::LocatorFilterEntry &selection,
                                    QString * /*newText*/,
                                    int * /*selectionStart*/,
                                    int * /*selectionLength*/) const
--- a/src/plugins/languageclient/locatorfilter.h
+++ b/src/plugins/languageclient/locatorfilter.h
@@ -49,7 +49,7 @@ public:
    void prepareSearch(const QString &entry) override;
    QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                               const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                QString *newText,
                int *selectionStart,
                int *selectionLength) const override;
@@ -103,7 +103,7 @@ public:
    void prepareSearch(const QString &entry, const QVector<Client *> &clients);
    QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                               const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                QString *newText,
                int *selectionStart,
                int *selectionLength) const override;
--- a/src/plugins/macros/macrolocatorfilter.cpp
+++ b/src/plugins/macros/macrolocatorfilter.cpp
@@ -85,7 +85,7 @@ QList<Core::LocatorFilterEntry> MacroLocatorFilter::matchesFor(QFutureInterface<
    return betterEntries;
 }

-void MacroLocatorFilter::accept(Core::LocatorFilterEntry selection,
+void MacroLocatorFilter::accept(const Core::LocatorFilterEntry &selection,
                                QString *newText, int *selectionStart, int *selectionLength) const
 {
    Q_UNUSED(newText)
--- a/src/plugins/macros/macrolocatorfilter.h
+++ b/src/plugins/macros/macrolocatorfilter.h
@@ -42,7 +42,7 @@ public:

    QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                               const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                QString *newText, int *selectionStart, int *selectionLength) const override;

 private:
--- a/src/plugins/qmljstools/qmljsfunctionfilter.cpp
+++ b/src/plugins/qmljstools/qmljsfunctionfilter.cpp
@@ -95,7 +95,7 @@ QList<Core::LocatorFilterEntry> FunctionFilter::matchesFor(
    return std::accumulate(std::begin(entries), std::end(entries), QList<Core::LocatorFilterEntry>());
 }

-void FunctionFilter::accept(Core::LocatorFilterEntry selection,
+void FunctionFilter::accept(const Core::LocatorFilterEntry &selection,
                            QString *newText, int *selectionStart, int *selectionLength) const
 {
    Q_UNUSED(newText)
--- a/src/plugins/qmljstools/qmljsfunctionfilter.h
+++ b/src/plugins/qmljstools/qmljsfunctionfilter.h
@@ -42,7 +42,7 @@ public:

    QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                               const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                QString *newText, int *selectionStart, int *selectionLength) const override;

 private:
--- a/src/plugins/texteditor/linenumberfilter.cpp
+++ b/src/plugins/texteditor/linenumberfilter.cpp
@@ -90,7 +90,7 @@ QList<LocatorFilterEntry> LineNumberFilter::matchesFor(QFutureInterface<LocatorF
    return value;
 }

-void LineNumberFilter::accept(LocatorFilterEntry selection,
+void LineNumberFilter::accept(const LocatorFilterEntry &selection,
                              QString *newText, int *selectionStart, int *selectionLength) const
 {
    Q_UNUSED(newText)
--- a/src/plugins/texteditor/linenumberfilter.h
+++ b/src/plugins/texteditor/linenumberfilter.h
@@ -46,7 +46,7 @@ public:
    void prepareSearch(const QString &entry) override;
    QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                               const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                QString *newText, int *selectionStart, int *selectionLength) const override;

 private: