feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Fix crashes in connection view

Browse Source 
- Fix for connections order in view
 - Fix for binding and connection editor init crash

Change-Id: If0faf401b8e89a5548c65f07284138e869612c95
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Aleksei German
2020-06-22 11:45:14 +02:00
parent 538b097756
commit 27d4f4b663
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/qmldesigner/components/bindingeditor/bindingeditorwidget.cpp
View File

@@ -134,6 +134,7 @@ BindingEditorFactory::BindingEditorFactory()
{ {
setId(BINDINGEDITOR_CONTEXT_ID); setId(BINDINGEDITOR_CONTEXT_ID);
setDisplayName(QCoreApplication::translate("OpenWith::Editors", QmlDesigner::BINDINGEDITOR_CONTEXT_ID)); setDisplayName(QCoreApplication::translate("OpenWith::Editors", QmlDesigner::BINDINGEDITOR_CONTEXT_ID));
setEditorActionHandlers(0);
setDocumentCreator([]() { return new BindingDocument; }); setDocumentCreator([]() { return new BindingDocument; });
setEditorWidgetCreator([]() { return new BindingEditorWidget; }); setEditorWidgetCreator([]() { return new BindingEditorWidget; });

3
src/plugins/qmldesigner/components/connectioneditor/connectionmodel.cpp
View File

@@ -219,9 +219,6 @@ void ConnectionModel::updateTargetNode(int rowNumber)
connectionNode.bindingProperty("target").setExpression(newTarget); connectionNode.bindingProperty("target").setExpression(newTarget);
}); });
QStandardItem* idItem = item(rowNumber, 0);
updateCustomData(idItem, signalHandlerProperty);
} else { } else {
qWarning() << "BindingModel::updatePropertyName invalid target id"; qWarning() << "BindingModel::updatePropertyName invalid target id";
} }