feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Remove AnalyzerRunControl::pause etc

Browse Source 
Only supported by CallGrind, and still functional there.

This interface might be useful to move to the ProjectExplorer::RunControl
base class, as similar functionality is present e.g. in the QmlProfiler.

Change-Id: Ie1f8a044ace77aea7ed3c1296847cc7497bac409
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2016-05-30 14:05:33 +02:00
parent ea0d3f9ac5
commit 2845d75849
2 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/debugger/analyzer/analyzerruncontrol.h
View File

@@ -47,11 +47,6 @@ class DEBUGGER_EXPORT AnalyzerRunControl : public ProjectExplorer::RunControl
public: public:
AnalyzerRunControl(ProjectExplorer::RunConfiguration *runConfiguration, Core::Id runMode); AnalyzerRunControl(ProjectExplorer::RunConfiguration *runConfiguration, Core::Id runMode);
/// Controller actions.
virtual bool canPause() const { return false; }
virtual void pause() {}
virtual void unpause() {}
virtual void notifyRemoteSetupDone(Utils::Port) {} virtual void notifyRemoteSetupDone(Utils::Port) {}
virtual void notifyRemoteFinished() {} virtual void notifyRemoteFinished() {}

6
src/plugins/valgrind/callgrindengine.h
View File

@@ -44,14 +44,12 @@ public:
Valgrind::Callgrind::ParseData *takeParserData(); Valgrind::Callgrind::ParseData *takeParserData();
bool canPause() const override { return true; }
public slots: public slots:
/// controller actions /// controller actions
void dump(); void dump();
void reset(); void reset();
void pause() override; void pause();
void unpause() override; void unpause();
/// marks the callgrind process as paused /// marks the callgrind process as paused
/// calls pause() and unpause() if there's an active run /// calls pause() and unpause() if there's an active run