feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Inline RunConfiguration::isActive

Browse Source 
... into the only internal caller.

The use there is dubious to some degree.

Change-Id: Icfa7437b3fdaa4dbd73fe9965a88abf4700cd3e0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2020-02-24 14:58:36 +01:00
parent be2da106ee
commit 2cd44a546f
2 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/projectexplorer/runconfiguration.cpp
View File

@@ -204,11 +204,6 @@ RunConfiguration::RunConfiguration(Target *target, Core::Id id)
RunConfiguration::~RunConfiguration() = default; RunConfiguration::~RunConfiguration() = default;
bool RunConfiguration::isActive() const
{
return target()->isActive() && target()->activeRunConfiguration() == this;
}
QString RunConfiguration::disabledReason() const QString RunConfiguration::disabledReason() const
{ {
BuildSystem *bs = activeBuildSystem(); BuildSystem *bs = activeBuildSystem();
@@ -305,7 +300,9 @@ void RunConfiguration::update()
emit enabledChanged(); emit enabledChanged();
if (isActive() && project() == SessionManager::startupProject()) const bool isActive = target()->isActive() && target()->activeRunConfiguration() == this;
if (isActive && project() == SessionManager::startupProject())
emit ProjectExplorerPlugin::instance()->updateRunActions(); emit ProjectExplorerPlugin::instance()->updateRunActions();
} }

2
src/plugins/projectexplorer/runconfiguration.h
View File

@@ -127,8 +127,6 @@ class PROJECTEXPLORER_EXPORT RunConfiguration : public ProjectConfiguration
public: public:
~RunConfiguration() override; ~RunConfiguration() override;
bool isActive() const;
virtual QString disabledReason() const; virtual QString disabledReason() const;
virtual bool isEnabled() const; virtual bool isEnabled() const;