forked from qt-creator/qt-creator
QmlProfiler: avoid using Q_FOREACH over QVarLengthArray
The squeeze() function is called by clients for QVLA's, which means it's copying 1-2KiB of data (depending on sizeof(value_type)) just to iterate over a small part of it. Use a C++11 ranged for loop. Change-Id: I2c33ae0c5a3d9d941cd9e385fc6bbb4fb0fa3c2c Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
@@ -251,7 +251,7 @@ private:
|
|||||||
squeeze(const Container &numbers)
|
squeeze(const Container &numbers)
|
||||||
{
|
{
|
||||||
using Small = typename QIntegerForSize<sizeof(Number) / 2>::Signed;
|
using Small = typename QIntegerForSize<sizeof(Number) / 2>::Signed;
|
||||||
foreach (Number item, numbers) {
|
for (Number item : numbers) {
|
||||||
if (!squeezable<Number, Small>(item))
|
if (!squeezable<Number, Small>(item))
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user