feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlJS: Fix performance problem in Snapshot.

Browse Source 
Don't use QMultiHash::values(key), it rebuilds the values list from
scratch for each lookup.

Reviewed-by: Roberto Raggi
This commit is contained in:
Christian Kamm
2010-08-31 10:23:48 +02:00
parent 3499fcb18e
commit 2e8ec2f9e6
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/libs/qmljs/qmljsdocument.cpp
View File

@@ -339,7 +339,7 @@ void Snapshot::insert(const Document::Ptr &document)
const QString path = document->path();
remove(fileName);
_documentsByPath.insert(path, document);
_documentsByPath[path].append(document);
_documents.insert(fileName, document);
}
}
@@ -353,7 +353,12 @@ void Snapshot::remove(const QString &fileName)
{
Document::Ptr doc = _documents.value(fileName);
if (!doc.isNull()) {
_documentsByPath.remove(doc->path(), doc);
const QString &path = doc->path();
QList<Document::Ptr> docs = _documentsByPath.value(path);
docs.removeAll(doc);
_documentsByPath[path] = docs;
_documents.remove(fileName);
}
}
@@ -378,7 +383,7 @@ Document::Ptr Snapshot::document(const QString &fileName) const
QList<Document::Ptr> Snapshot::documentsInDirectory(const QString &path) const
{
return _documentsByPath.values(QDir::cleanPath(path));
return _documentsByPath.value(QDir::cleanPath(path));
}
LibraryInfo Snapshot::libraryInfo(const QString &path) const