feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ExtensionManager: Guard usage of __DATE__

Browse Source 
Use __DATE__ only if no reproducible build is required.
Don't show a date in the ExtensionManager if there is none.

Amends: 07000281da

Change-Id: I419ce742c6c7358d7a294ea4d239aca07ef7890e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Alessandro Portale
2024-09-19 17:50:30 +02:00
parent 1dd2a08eac
commit 2eb97663c7
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/extensionmanager/extensionmanagerwidget.cpp
View File

@@ -609,7 +609,11 @@ void ExtensionManagerWidget::updateView(const QModelIndex &current)
}; };
const QDate dateUpdated = current.data(RoleDateUpdated).toDate(); const QDate dateUpdated = current.data(RoleDateUpdated).toDate();
m_dateUpdated->setText(dateUpdated.toString()); const bool hasDateUpdated = dateUpdated.isValid();
if (hasDateUpdated)
m_dateUpdated->setText(dateUpdated.toString());
m_dateUpdatedTitle->setVisible(hasDateUpdated);
m_dateUpdated->setVisible(hasDateUpdated);
const QStringList tags = current.data(RoleTags).toStringList(); const QStringList tags = current.data(RoleTags).toStringList();
m_tags->setTags(tags); m_tags->setTags(tags);

2
src/plugins/extensionmanager/extensionsmodel.cpp
View File

@@ -209,8 +209,10 @@ QVariant ExtensionsModelPrivate::dataFromLocalPlugin(int index, int role) const
: QStringList(platformsPattern); : QStringList(platformsPattern);
return platforms; return platforms;
} }
#ifdef QTC_SHOW_BUILD_DATE
case RoleDateUpdated: case RoleDateUpdated:
return QDate::fromString(QLatin1String(__DATE__), "MMM dd yyyy"); return QDate::fromString(QLatin1String(__DATE__), "MMM dd yyyy");
#endif
case RoleVendor: case RoleVendor:
return pluginSpec->vendor(); return pluginSpec->vendor();
case RoleVendorId: case RoleVendorId: