feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Sqlite: Forbid double quotes which are not part of the SQL standard

Browse Source 
It's anyway easier to write single quotes.

Change-Id: Ie71c39d9cdd83e0b898efe70a1912d8257ac991e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Marco Bubke
2020-05-16 01:52:40 +02:00
committed by Tim Jenssen
parent 5d5d100733
commit 2f6a226dd3
3 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libs/sqlite/createtablesqlstatementbuilder.cpp
View File

@@ -173,9 +173,9 @@ public:
columnDefinitionString.append(Utils::SmallString::number(defaultValue.value.toFloat()));
break;
case Sqlite::ValueType::String:
columnDefinitionString.append("\"");
columnDefinitionString.append("'");
columnDefinitionString.append(defaultValue.value.toStringView());
columnDefinitionString.append("\"");
columnDefinitionString.append("'");
break;
}
}

2
src/libs/sqlite/sqlite-lib.pri
View File

@@ -53,7 +53,7 @@ DEFINES += SQLITE_THREADSAFE=2 SQLITE_ENABLE_FTS5 \
SQLITE_OMIT_DEPRECATED SQLITE_OMIT_DECLTYPE \
SQLITE_MAX_EXPR_DEPTH=0 SQLITE_OMIT_SHARED_CACHE SQLITE_USE_ALLOCA \
SQLITE_ENABLE_MEMORY_MANAGEMENT SQLITE_ENABLE_NULL_TRIM SQLITE_OMIT_EXPLAIN \
SQLITE_OMIT_LOAD_EXTENSION SQLITE_OMIT_UTF16
SQLITE_OMIT_LOAD_EXTENSION SQLITE_OMIT_UTF16 SQLITE_DQS=0
OTHER_FILES += README.md

15
tests/unit/unittest/symbolquery-test.cpp
View File

@@ -74,15 +74,18 @@ class SymbolQuerySlowTest : public testing::Test
protected:
void SetUp() override
{
database.execute("INSERT INTO sources VALUES (1, 1, \"filename.h\")");
database.execute("INSERT INTO sources VALUES (2, 1, \"filename.cpp\")");
database.execute("INSERT INTO directories VALUES (1, \"/path/to\")");
database.execute("INSERT INTO sources VALUES (1, 1, 'filename.h')");
database.execute("INSERT INTO sources VALUES (2, 1, 'filename.cpp')");
database.execute("INSERT INTO directories VALUES (1, '/path/to')");
database.execute("INSERT INTO locations VALUES (1, 2, 3, 1, 2)");
database.execute("INSERT INTO locations VALUES (1, 4, 6, 2, 1)");
database.execute("INSERT INTO locations VALUES (1, 20, 36, 2, 3)");
database.execute("INSERT INTO symbols VALUES (1, \"functionusr\", \"Function\", 3, \"void function(int)\")");
database.execute("INSERT INTO symbols VALUES (2, \"classusr\", \"Class\", 2, \"class Class final\")");
database.execute("INSERT INTO symbols VALUES (3, \"enumusr\", \"Enum\", 1, \"enum Enum : char\")");
database.execute(
"INSERT INTO symbols VALUES (1, 'functionusr', 'Function', 3, 'void function(int)')");
database.execute(
"INSERT INTO symbols VALUES (2, 'classusr', 'Class', 2, 'class Class final')");
database.execute(
"INSERT INTO symbols VALUES (3, 'enumusr', 'Enum', 1, 'enum Enum : char')");
}
protected: