feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Cmake: Don't take QStringRefs of a temporary QString

Browse Source 
This crashes.

Change-Id: I3f81466f504fdff8d47372425ea8f84048f89b76
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Ulf Hermann
2016-11-25 16:56:56 +01:00
parent f4223aa4f6
commit 31749b76b8
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/cmakeprojectmanager/cmaketool.cpp
View File

@@ -411,7 +411,8 @@ void CMakeTool::fetchVersionFromVersionOutput() const
return; return;
QRegularExpression versionLine("^cmake version ((\\d+).(\\d+).(\\d+).*)$"); QRegularExpression versionLine("^cmake version ((\\d+).(\\d+).(\\d+).*)$");
for (const QStringRef &line : response.stdOut().splitRef(QLatin1Char('\n'))) { const QString responseText = response.stdOut();
for (const QStringRef &line : responseText.splitRef(QLatin1Char('\n'))) {
QRegularExpressionMatch match = versionLine.match(line); QRegularExpressionMatch match = versionLine.match(line);
if (!match.hasMatch()) if (!match.hasMatch())
continue; continue;