feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Link with Qt: Remove now harmful check

Browse Source 
The check was trying to find out if the Qt Creator installation is part
of the online installer or a Qt installer, by checking if there are
install settings without the key "Settings/InstallSettings".

Since we made Qt Creator optional in the installer, the install settings
contain that redirection key anyway, so it is no longer an indicator for
Qt Creator being part of the online or an Qt installer anymore.

Actually the check now _disables_ the Link with Qt button for the
commercial Qt Creator offline installer on macOS, because that ships
install settings that add the plugin path to the commercial plugins
outside the Qt Creator app bundle, but does not contain "Settings/
InstallSettings".

Just remove the check.

Change-Id: I88c3ef007a728dff0f4214e5a5683ffcede23796
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Eike Ziller
2023-02-15 17:10:26 +01:00
parent 5c98eaf592
commit 330a6f793c
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/qtsupport/qtoptionspage.cpp
View File

@@ -852,14 +852,6 @@ static bool canLinkWithQt(QString *toolTip)
tip << Tr::tr("%1's resource directory is not writable.")
.arg(Core::Constants::IDE_DISPLAY_NAME);
}
// guard against redirecting Qt Creator that is part of a Qt installations
// TODO this fails for pre-releases in the online installer
// TODO this will fail when make Qt Creator non-required in the Qt installers
if (installSettingsExist && !installSettingsValue) {
canLink = false;
tip << Tr::tr("%1 is part of a Qt installation.")
.arg(Core::Constants::IDE_DISPLAY_NAME);
}
const FilePath link = installSettingsValue ? *installSettingsValue : FilePath();
if (!link.isEmpty())
tip << Tr::tr("%1 is currently linked to \"%2\".")