feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Core: Consider keyboard navigation in output window scrolling logic

Browse Source 
... by using QAbstractSlider::actionTriggered() instead of the mouse-
centric signals.

Fixes: QTCREATORBUG-25557
Change-Id: I0092fbfcb8fefb3a234bfb1592a2483bdc9e68d3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Christian Kandeler
2021-04-08 12:22:06 +02:00
committed by Orgad Shaneh
parent 12645efba0
commit 33a38394b4
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/coreplugin/outputwindow.cpp
View File

@@ -153,9 +153,7 @@ OutputWindow::OutputWindow(Context context, const QString &settingsKey, QWidget
EditorManager::openEditorAt(fp.toString(), line, column); EditorManager::openEditorAt(fp.toString(), line, column);
}); });
connect(verticalScrollBar(), &QAbstractSlider::sliderMoved, connect(verticalScrollBar(), &QAbstractSlider::actionTriggered,
this, &OutputWindow::updateAutoScroll);
connect(verticalScrollBar(), &QAbstractSlider::sliderReleased,
this, &OutputWindow::updateAutoScroll); this, &OutputWindow::updateAutoScroll);
undoAction->setEnabled(false); undoAction->setEnabled(false);
@@ -451,7 +449,7 @@ void OutputWindow::handleOutputChunk(const QString &output, OutputFormat format)
void OutputWindow::updateAutoScroll() void OutputWindow::updateAutoScroll()
{ {
d->scrollToBottom = verticalScrollBar()->value() >= verticalScrollBar()->maximum() - 1; d->scrollToBottom = verticalScrollBar()->sliderPosition() >= verticalScrollBar()->maximum() - 1;
} }
void OutputWindow::setMaxCharCount(int count) void OutputWindow::setMaxCharCount(int count)