feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QtVersionManager: Make qtVersionsChanged args default

Browse Source 
Change-Id: Ifb420ebdeefe18114f82c48c2c4c49d808caef0c
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2024-01-09 00:22:06 +01:00
parent 1c8e88651c
commit 33ef73daf9
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/qtsupport/qtversionmanager.cpp
View File

@@ -163,8 +163,7 @@ void QtVersionManagerImpl::triggerQtVersionRestore()
NANOTRACE_SCOPE("QtSupport", "QtVersionManagerImpl::qtVersionsLoaded"); NANOTRACE_SCOPE("QtSupport", "QtVersionManagerImpl::qtVersionsLoaded");
emit QtVersionManager::instance()->qtVersionsLoaded(); emit QtVersionManager::instance()->qtVersionsLoaded();
} }
emit QtVersionManager::instance()->qtVersionsChanged( emit QtVersionManager::instance()->qtVersionsChanged(m_versions.keys());
m_versions.keys(), QList<int>(), QList<int>());
const FilePath configFileName = globalSettingsFileName(); const FilePath configFileName = globalSettingsFileName();
if (configFileName.exists()) { if (configFileName.exists()) {
@@ -478,7 +477,7 @@ void QtVersionManager::addVersion(QtVersion *version)
int uniqueId = version->uniqueId(); int uniqueId = version->uniqueId();
m_versions.insert(uniqueId, version); m_versions.insert(uniqueId, version);
emit QtVersionManager::instance()->qtVersionsChanged(QList<int>() << uniqueId, QList<int>(), QList<int>()); emit QtVersionManager::instance()->qtVersionsChanged({uniqueId});
qtVersionManagerImpl().saveQtVersions(); qtVersionManagerImpl().saveQtVersions();
} }
@@ -486,7 +485,7 @@ void QtVersionManager::removeVersion(QtVersion *version)
{ {
QTC_ASSERT(version, return); QTC_ASSERT(version, return);
m_versions.remove(version->uniqueId()); m_versions.remove(version->uniqueId());
emit QtVersionManager::instance()->qtVersionsChanged(QList<int>(), QList<int>() << version->uniqueId(), QList<int>()); emit QtVersionManager::instance()->qtVersionsChanged({}, {version->uniqueId()});
qtVersionManagerImpl().saveQtVersions(); qtVersionManagerImpl().saveQtVersions();
delete version; delete version;
} }

3
src/plugins/qtsupport/qtversionmanager.h
View File

@@ -43,7 +43,8 @@ public:
signals: signals:
// content of QtVersion objects with qmake path might have changed // content of QtVersion objects with qmake path might have changed
void qtVersionsChanged(const QList<int> &addedIds, const QList<int> &removedIds, const QList<int> &changedIds); void qtVersionsChanged(const QList<int> &addedIds, const QList<int> &removedIds = {},
const QList<int> &changedIds = {});
void qtVersionsLoaded(); void qtVersionsLoaded();
private: private: