CppIncludesFilter: Reimplement matchers()

Change-Id: Ie449a9560203e50285bd0dab7bed7f8a5495628a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Jarek Kobus
2023-04-22 12:00:59 +02:00
parent 9df9185382
commit 341ade96fb
2 changed files with 54 additions and 1 deletions

View File

@@ -97,6 +97,36 @@ void CppIncludesIterator::fetchMore()
}
}
static FilePaths generateFilePaths(const QFuture<void> &future,
const CPlusPlus::Snapshot &snapshot,
const std::unordered_set<FilePath> &inputFilePaths)
{
FilePaths results;
std::unordered_set<FilePath> resultsCache;
std::unordered_set<FilePath> queuedPaths = inputFilePaths;
while (!queuedPaths.empty()) {
if (future.isCanceled())
return {};
const auto iterator = queuedPaths.cbegin();
const FilePath filePath = *iterator;
queuedPaths.erase(iterator);
const CPlusPlus::Document::Ptr doc = snapshot.document(filePath);
if (!doc)
continue;
const FilePaths includedFiles = doc->includedFiles();
for (const FilePath &includedFile : includedFiles) {
if (resultsCache.emplace(includedFile).second) {
queuedPaths.emplace(includedFile);
results.append(includedFile);
}
}
}
return results;
}
CppIncludesFilter::CppIncludesFilter()
{
setId(Constants::INCLUDES_FILTER_ID);
@@ -124,6 +154,27 @@ CppIncludesFilter::CppIncludesFilter()
this, &CppIncludesFilter::invalidateCache);
connect(DocumentModel::model(), &QAbstractItemModel::modelReset,
this, &CppIncludesFilter::invalidateCache);
const auto generatorProvider = [] {
// This body runs in main thread
std::unordered_set<FilePath> inputFilePaths;
for (Project *project : ProjectManager::projects()) {
const FilePaths allFiles = project->files(Project::SourceFiles);
for (const FilePath &filePath : allFiles)
inputFilePaths.insert(filePath);
}
const QList<DocumentModel::Entry *> entries = DocumentModel::entries();
for (DocumentModel::Entry *entry : entries) {
if (entry)
inputFilePaths.insert(entry->filePath());
}
const CPlusPlus::Snapshot snapshot = CppModelManager::instance()->snapshot();
return [snapshot, inputFilePaths](const QFuture<void> &future) {
// This body runs in non-main thread
return generateFilePaths(future, snapshot, inputFilePaths);
};
};
m_cache.setGeneratorProvider(generatorProvider);
}
void CppIncludesFilter::prepareSearch(const QString &entry)
@@ -150,6 +201,7 @@ void CppIncludesFilter::prepareSearch(const QString &entry)
void CppIncludesFilter::invalidateCache()
{
m_cache.invalidate();
m_needsUpdate = true;
setFileIterator(nullptr); // clean up
}

View File

@@ -12,13 +12,14 @@ class CppIncludesFilter : public Core::BaseFileFilter
public:
CppIncludesFilter();
// ILocatorFilter interface
public:
void prepareSearch(const QString &entry) override;
private:
Core::LocatorMatcherTasks matchers() final { return {m_cache.matcher()}; }
void invalidateCache();
Core::LocatorFileCache m_cache;
bool m_needsUpdate = true;
};