feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Turn pointer into value

Browse Source 
... which avoids a raw pointer which needs additional "management".

Change-Id: I9c478b4043a563b00ced09de8366657eaf34c349
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Bernhard Beschow
2021-01-26 16:41:28 +01:00
parent a842409d2c
commit 35021ec2da
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/autotest/autotestplugin.cpp
View File

@@ -94,7 +94,7 @@ public:
AutotestPluginPrivate();
~AutotestPluginPrivate() override;
TestNavigationWidgetFactory *m_navigationWidgetFactory = nullptr;
TestNavigationWidgetFactory m_navigationWidgetFactory;
TestResultsPane *m_resultsPane = nullptr;
QMap<QString, ChoicePair> m_runconfigCache;
@@ -149,7 +149,6 @@ AutotestPluginPrivate::AutotestPluginPrivate()
m_frameworkManager.registerTestTool(new CTestTool);
m_frameworkManager.synchronizeSettings(ICore::settings());
m_navigationWidgetFactory = new TestNavigationWidgetFactory;
m_resultsPane = TestResultsPane::instance();
auto panelFactory = new ProjectExplorer::ProjectPanelFactory();
@@ -186,7 +185,6 @@ AutotestPluginPrivate::~AutotestPluginPrivate()
s_projectSettings.clear();
}
delete m_navigationWidgetFactory;
delete m_resultsPane;
}