feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlJS: Fix possible crash

Browse Source 
For a valid AST id should be never empty.
A crash has been reported. though. Most likely the parser
injected a UiQualifiedId for an incomplete document.

Change-Id: Id2f1b25cf9d78982524d7aaff2b43210e1ae2a3b
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
This commit is contained in:
Thomas Hartmann
2016-04-13 15:08:07 +02:00
parent 6a10db9a43
commit 354abe5ad8
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libs/qmljs/qmljscheck.cpp
View File

@@ -719,6 +719,10 @@ void Check::endVisit(UiObjectInitializer *)
void Check::checkProperty(UiQualifiedId *qualifiedId) void Check::checkProperty(UiQualifiedId *qualifiedId)
{ {
const QString id = toString(qualifiedId); const QString id = toString(qualifiedId);
if (id.isEmpty())
return;
if (id.at(0).isLower()) { if (id.at(0).isLower()) {
if (m_propertyStack.top().contains(id)) if (m_propertyStack.top().contains(id))
addMessage(ErrPropertiesCanOnlyHaveOneBinding, fullLocationForQualifiedId(qualifiedId)); addMessage(ErrPropertiesCanOnlyHaveOneBinding, fullLocationForQualifiedId(qualifiedId));