ExtensionSystem: Remove PluginSpec::isHiddenByDefault

Not used anymore.

Change-Id: Ic73ba3024b9e6157ff044cb23450fc9dad3c4c02
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

doc/qtcreatordev/src/plugin-metadata.qdoc

@@ -81,13 +81,6 @@
                 If set, the respective plugin is not loaded by default but must be explicitly
                 enabled by the user. This should be done for plugins which are not expected
                 to be used by so many people as to justify the additional resource consumption.
-        \row
-            \li HiddenByDefault
-            \li Boolean
-            \li Optional. Defaults to \c false.
-                If set, the plugin is not shown in the default view in the
-                \uicontrol {About Plugins...} dialog, but only if the user requests seeing all
-                plugins. It is still shown with the \c{-version} command line option.
         \row
             \li Required
             \li Boolean

src/libs/extensionsystem/pluginspec.cpp

@@ -315,14 +315,6 @@ bool PluginSpec::isRequired() const
     return d->required;
 }
 
-/*!
-    Returns whether the plugin is hidden by default.
-*/
-bool PluginSpec::isHiddenByDefault() const
-{
-    return d->hiddenByDefault;
-}
-
 /*!
     Returns whether the plugin has its experimental flag set.
 */
@@ -554,7 +546,6 @@ namespace {
     const char PLUGIN_VERSION[] = "Version";
     const char PLUGIN_COMPATVERSION[] = "CompatVersion";
     const char PLUGIN_REQUIRED[] = "Required";
-    const char PLUGIN_HIDDEN_BY_DEFAULT[] = "HiddenByDefault";
     const char PLUGIN_EXPERIMENTAL[] = "Experimental";
     const char PLUGIN_DISABLED_BY_DEFAULT[] = "DisabledByDefault";
     const char VENDOR[] = "Vendor";
@@ -744,12 +735,6 @@ bool PluginSpecPrivate::readMetaData(const QJsonObject &pluginMetaData)
     required = value.toBool(false);
     qCDebug(pluginLog) << "required =" << required;
 
-    value = metaData.value(QLatin1String(PLUGIN_HIDDEN_BY_DEFAULT));
-    if (!value.isUndefined() && !value.isBool())
-        return reportError(msgValueIsNotABool(PLUGIN_HIDDEN_BY_DEFAULT));
-    hiddenByDefault = value.toBool(false);
-    qCDebug(pluginLog) << "hiddenByDefault =" << hiddenByDefault;
-
     value = metaData.value(QLatin1String(PLUGIN_EXPERIMENTAL));
     if (!value.isUndefined() && !value.isBool())
         return reportError(msgValueIsNotABool(PLUGIN_EXPERIMENTAL));

src/libs/extensionsystem/pluginspec.h

@@ -95,7 +95,6 @@ public:
     QRegularExpression platformSpecification() const;
     bool isAvailableForHostPlatform() const;
     bool isRequired() const;
-    bool isHiddenByDefault() const;
     bool isExperimental() const;
     bool isEnabledByDefault() const;
     bool isEnabledBySettings() const;

src/plugins/clangpchmanager/ClangPchManager.json.in

@@ -3,7 +3,6 @@
     \"Version\" : \"$$QTCREATOR_VERSION\",
     \"CompatVersion\" : \"$$QTCREATOR_COMPAT_VERSION\",
     \"Experimental\" : true,
-    \"HiddenByDefault\": true,
     \"Vendor\" : \"The Qt Company Ltd\",
     \"Copyright\" : \"(C) $$QTCREATOR_COPYRIGHT_YEAR The Qt Company Ltd\",
     \"License\" : [ \"Commercial Usage\",

src/plugins/coreplugin/Core.json.in

@@ -3,7 +3,6 @@
     \"Version\" : \"$$QTCREATOR_VERSION\",
     \"CompatVersion\" : \"$$QTCREATOR_COMPAT_VERSION\",
     \"Required\" : true,
-    \"HiddenByDefault\" : true,
     \"Vendor\" : \"The Qt Company Ltd\",
     \"Copyright\" : \"(C) $$QTCREATOR_COPYRIGHT_YEAR The Qt Company Ltd\",
     \"License\" : [ \"Commercial Usage\",

src/plugins/cpptools/CppTools.json.in

@@ -2,7 +2,6 @@
     \"Name\" : \"CppTools\",
     \"Version\" : \"$$QTCREATOR_VERSION\",
     \"CompatVersion\" : \"$$QTCREATOR_COMPAT_VERSION\",
-    \"HiddenByDefault\" : true,
     \"Vendor\" : \"The Qt Company Ltd\",
     \"Copyright\" : \"(C) $$QTCREATOR_COPYRIGHT_YEAR The Qt Company Ltd\",
     \"License\" : [ \"Commercial Usage\",

src/plugins/helloworld/HelloWorld.json.in

@@ -3,7 +3,6 @@
     \"Version\" : \"$$QTCREATOR_VERSION\",
     \"CompatVersion\" : \"$$QTCREATOR_COMPAT_VERSION\",
     \"DisabledByDefault\" : true,
-    \"HiddenByDefault\" : true,
     \"Vendor\" : \"The Qt Company Ltd\",
     \"Copyright\" : \"(C) $$QTCREATOR_COPYRIGHT_YEAR The Qt Company Ltd\",
     \"License\" : [ \"Commercial Usage\",

src/plugins/projectexplorer/ProjectExplorer.json.in

@@ -2,7 +2,6 @@
     \"Name\" : \"ProjectExplorer\",
     \"Version\" : \"$$QTCREATOR_VERSION\",
     \"CompatVersion\" : \"$$QTCREATOR_COMPAT_VERSION\",
-    \"HiddenByDefault\" : true,
     \"Vendor\" : \"The Qt Company Ltd\",
     \"Copyright\" : \"(C) $$QTCREATOR_COPYRIGHT_YEAR The Qt Company Ltd\",
     \"License\" : [ \"Commercial Usage\",

src/plugins/qmljstools/QmlJSTools.json.in

@@ -2,7 +2,6 @@
     \"Name\" : \"QmlJSTools\",
     \"Version\" : \"$$QTCREATOR_VERSION\",
     \"CompatVersion\" : \"$$QTCREATOR_COMPAT_VERSION\",
-    \"HiddenByDefault\" : true,
     \"Vendor\" : \"The Qt Company Ltd\",
     \"Copyright\" : \"(C) $$QTCREATOR_COPYRIGHT_YEAR The Qt Company Ltd\",
     \"License\" : [ \"Commercial Usage\",

src/plugins/qtsupport/QtSupport.json.in

@@ -2,7 +2,6 @@
     \"Name\" : \"QtSupport\",
     \"Version\" : \"$$QTCREATOR_VERSION\",
     \"CompatVersion\" : \"$$QTCREATOR_COMPAT_VERSION\",
-    \"HiddenByDefault\" : true,
     \"Vendor\" : \"The Qt Company Ltd\",
     \"Copyright\" : \"(C) $$QTCREATOR_COPYRIGHT_YEAR The Qt Company Ltd\",
     \"License\" : [ \"Commercial Usage\",

src/plugins/vcsbase/VcsBase.json.in

@@ -2,7 +2,6 @@
     \"Name\" : \"VcsBase\",
     \"Version\" : \"$$QTCREATOR_VERSION\",
     \"CompatVersion\" : \"$$QTCREATOR_COMPAT_VERSION\",
-    \"HiddenByDefault\" : true,
     \"Vendor\" : \"The Qt Company Ltd\",
     \"Copyright\" : \"(C) $$QTCREATOR_COPYRIGHT_YEAR The Qt Company Ltd\",
     \"License\" : [ \"Commercial Usage\",