feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Make GenericMakeStep not immutable

Browse Source 
GenericMakeStep is currently immutable. This is quite annoying since
it's possible to create GenericMakeStep but it's not possible to remove
them.

Fix: make GenericMakeStep not immutable

Merge-request: 117
Reviewed-by: Thorbjørn Lindeijer <thorbjorn.lindeijer@nokia.com>
Reviewed-by: dt
Reviewed-by: Tobias Hunger
This commit is contained in:
Laurent Desmecht
2010-02-25 14:23:11 +01:00
committed by Thorbjørn Lindeijer
parent 5f9e4c7e0d
commit 38a5dedc45
1 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/genericprojectmanager/genericmakestep.cpp
View File

@@ -177,14 +177,7 @@ ProjectExplorer::BuildStepConfigWidget *GenericMakeStep::createConfigWidget()
bool GenericMakeStep::immutable() const
{
// Only make one GenericMakeStep immutable:
QList<BuildStep *> steps = buildConfiguration()->buildSteps();
int makestepCount = 0;
foreach (const BuildStep *bs, steps) {
if (qobject_cast<const GenericMakeStep *>(bs))
++makestepCount;
}
return makestepCount <= 1;
return false;
}
bool GenericMakeStep::buildsTarget(const QString &target) const