feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Project: Fix possible crash with projects without build configuration

Browse Source 
Do not allow to rename buildconfigurations if there are none.

Change-Id: I3da2ea9568c2dabf555685c3b27192bea8dcc009
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
This commit is contained in:
Tobias Hunger
2015-09-02 17:11:30 +02:00
parent 2186d0815a
commit 396c033707
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/projectexplorer/buildsettingspropertiespage.cpp
View File

@@ -199,7 +199,9 @@ void BuildSettingsWidget::updateBuildSettings()
clearWidgets(); clearWidgets();
// update buttons // update buttons
m_removeButton->setEnabled(m_target->buildConfigurations().size() > 1); QList<BuildConfiguration *> bcs = m_target->buildConfigurations();
m_removeButton->setEnabled(bcs.size() > 1);
m_renameButton->setEnabled(!bcs.isEmpty());
if (!m_buildConfiguration) if (!m_buildConfiguration)
return; return;
@@ -288,6 +290,7 @@ QString BuildSettingsWidget::uniqueName(const QString & name)
void BuildSettingsWidget::renameConfiguration() void BuildSettingsWidget::renameConfiguration()
{ {
QTC_ASSERT(m_buildConfiguration, return);
bool ok; bool ok;
QString name = QInputDialog::getText(this, tr("Rename..."), QString name = QInputDialog::getText(this, tr("Rename..."),
tr("New name for build configuration <b>%1</b>:"). tr("New name for build configuration <b>%1</b>:").