feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VcsBase: fix constness of VcsBaseClient member functions

Browse Source 
Member functions VcsBaseClient::createCommand() and vcsSynchronousExec()
should be const (ie. read-only functions)

Change-Id: I4db75c9e23d9d1abf316ce1a4e222a5f3b339b13
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Hugues Delorme
2014-05-19 18:26:02 +02:00
parent e23ac6f698
commit 3cd19a591f
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/vcsbase/vcsbaseclient.cpp
View File

@@ -316,7 +316,7 @@ Utils::SynchronousProcessResponse VcsBaseClient::vcsSynchronousExec(
const QString &workingDirectory,
const QStringList &args,
unsigned flags,
QTextCodec *outputCodec)
QTextCodec *outputCodec) const
{
const QString binary = settings()->binaryPath();
const int timeoutSec = settings()->intValue(VcsBaseClientSettings::timeoutKey);
@@ -603,7 +603,7 @@ QProcessEnvironment VcsBaseClient::processEnvironment() const
Command *VcsBaseClient::createCommand(const QString &workingDirectory,
VcsBase::VcsBaseEditorWidget *editor,
JobOutputBindMode mode)
JobOutputBindMode mode) const
{
Command *cmd = new Command(d->m_clientSettings->binaryPath(),
workingDirectory, processEnvironment());