feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Qnx: Pass some values by reference

Browse Source 
Change-Id: I6190cfa0b031a832222d89e3a37970a4440dbadb
Reviewed-by: Mehdi Fekari <mfekari@blackberry.com>
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Orgad Shaneh
2014-05-19 23:35:05 +03:00
committed by Orgad Shaneh
parent 5125a47955
commit e23ac6f698
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/qnx/blackberrydeviceconnectionmanager.cpp
View File

@@ -209,8 +209,8 @@ bool BlackBerryDeviceConnectionManager::hasValidSSHKeys() const
* @param privateKeyContent the private key content
* @param publicKeyContent the public key content
*/
bool BlackBerryDeviceConnectionManager::setSSHKeys(const QByteArray privateKeyContent,
const QByteArray publicKeyContent, QString *error)
bool BlackBerryDeviceConnectionManager::setSSHKeys(const QByteArray &privateKeyContent,
const QByteArray &publicKeyContent, QString *error)
{
const QString privateKey = privateKeyPath();
const QString publicKey = privateKey + QLatin1String(".pub");

2
src/plugins/qnx/blackberrydeviceconnectionmanager.h
View File

@@ -62,7 +62,7 @@ public:
const QString privateKeyPath() const;
bool hasValidSSHKeys() const;
bool setSSHKeys(const QByteArray privateKeyContent, const QByteArray publicKeyContent,
bool setSSHKeys(const QByteArray &privateKeyContent, const QByteArray &publicKeyContent,
QString *error);
signals:

4
src/plugins/qnx/qnxdeviceprocesssignaloperation.cpp
View File

@@ -35,7 +35,7 @@ using namespace Qnx;
using namespace Qnx::Internal;
QnxDeviceProcessSignalOperation::QnxDeviceProcessSignalOperation(
const QSsh::SshConnectionParameters sshParameters)
const QSsh::SshConnectionParameters &sshParameters)
: RemoteLinux::RemoteLinuxSignalOperation(sshParameters)
{
}
@@ -64,7 +64,7 @@ QString QnxDeviceProcessSignalOperation::interruptProcessByNameCommandLine(
BlackBerryDeviceProcessSignalOperation::BlackBerryDeviceProcessSignalOperation(
const QSsh::SshConnectionParameters sshParameters)
const QSsh::SshConnectionParameters &sshParameters)
: RemoteLinux::RemoteLinuxSignalOperation(sshParameters)
{
}

4
src/plugins/qnx/qnxdeviceprocesssignaloperation.h
View File

@@ -41,7 +41,7 @@ class QnxDeviceProcessSignalOperation : public RemoteLinux::RemoteLinuxSignalOpe
{
Q_OBJECT
protected:
explicit QnxDeviceProcessSignalOperation(const QSsh::SshConnectionParameters sshParameters);
explicit QnxDeviceProcessSignalOperation(const QSsh::SshConnectionParameters &sshParameters);
private:
QString killProcessByNameCommandLine(const QString &filePath) const;
@@ -54,7 +54,7 @@ class BlackBerryDeviceProcessSignalOperation : public RemoteLinux::RemoteLinuxSi
{
Q_OBJECT
protected:
explicit BlackBerryDeviceProcessSignalOperation(const QSsh::SshConnectionParameters sshParameters);
explicit BlackBerryDeviceProcessSignalOperation(const QSsh::SshConnectionParameters &sshParameters);
private:
QString killProcessByNameCommandLine(const QString &filePath) const;