feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

C++: fix local types and members

Browse Source 
It fixes code model when we have local type which contains a member
of other type, e.g.:
struct OtherType { int otherTypeMember; };
void foo()
{
    struct LocalType
    {
        int localTypeMember;
        OtherType ot;
    };

    LocalType lt;
    lt.ot.//no code completion
}

Change-Id: I018f492a6c48bfcbba0ef376ef005825e2b13f35
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
This commit is contained in:
Przemyslaw Gorszkowski
2013-07-04 09:09:35 +02:00
committed by Erik Verbruggen
parent 43a3334347
commit 3cde52846e
3 changed files with 218 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/libs/cplusplus/LookupContext.cpp
View File

@@ -360,6 +360,15 @@ ClassOrNamespace *LookupContext::lookupType(const Name *name, Scope *scope,
} else if (ClassOrNamespace *b = bindings()->lookupType(scope, enclosingTemplateInstantiation)) {
return b->lookupType(name);
} else if (Class *scopeAsClass = scope->asClass()) {
if (scopeAsClass->enclosingScope()->isBlock()) {
if (ClassOrNamespace *b = lookupType(scopeAsClass->name(),
scopeAsClass->enclosingScope(),
enclosingTemplateInstantiation,
typedefsBeingResolved)) {
return b->lookupType(name);
}
}
}
return 0;

202
src/plugins/cpptools/cppcompletion_test.cpp
View File

@@ -2825,3 +2825,205 @@ void CppToolsPlugin::test_completion_lambdaCalls_5()
QVERIFY(completions.contains(QLatin1String("S")));
QVERIFY(completions.contains(QLatin1String("bar")));
}
void CppToolsPlugin::test_completion_local_type_and_member_1()
{
TestData data;
data.srcText =
"struct OtherType { int otherTypeMember; };\n"
"void foo()\n"
"{\n"
" struct LocalType\n"
" {\n"
" int localTypeMember;\n"
" OtherType ot;\n"
" };\n"
" LocalType lt;\n"
" @\n"
" // padding so we get the scope right\n"
"}\n"
;
setup(&data);
Utils::ChangeSet change;
QString txt = QLatin1String("lt.ot.");
change.insert(data.pos, txt);
QTextCursor cursor(data.doc);
change.apply(&cursor);
data.pos += txt.length();
QStringList completions = getCompletions(data);
QCOMPARE(completions.size(), 2);
QVERIFY(completions.contains(QLatin1String("OtherType")));
QVERIFY(completions.contains(QLatin1String("otherTypeMember")));
}
void CppToolsPlugin::test_completion_local_type_and_member_2()
{
TestData data;
data.srcText =
"void foo()\n"
"{\n"
" struct OtherType { int otherTypeMember; };\n"
" struct LocalType\n"
" {\n"
" int localTypeMember;\n"
" OtherType ot;\n"
" };\n"
" LocalType lt;\n"
" @\n"
" // padding so we get the scope right\n"
"}\n"
;
setup(&data);
Utils::ChangeSet change;
QString txt = QLatin1String("lt.ot.");
change.insert(data.pos, txt);
QTextCursor cursor(data.doc);
change.apply(&cursor);
data.pos += txt.length();
QStringList completions = getCompletions(data);
QCOMPARE(completions.size(), 2);
QVERIFY(completions.contains(QLatin1String("OtherType")));
QVERIFY(completions.contains(QLatin1String("otherTypeMember")));
}
void CppToolsPlugin::test_completion_local_type_and_member_3()
{
TestData data;
data.srcText =
"void foo()\n"
"{\n"
" struct OtherType { int otherTypeMember; };\n"
" {\n"
" struct LocalType\n"
" {\n"
" int localTypeMember;\n"
" OtherType ot;\n"
" };\n"
" LocalType lt;\n"
" @\n"
" // padding so we get the scope right\n"
" }\n"
"}\n"
;
setup(&data);
Utils::ChangeSet change;
QString txt = QLatin1String("lt.ot.");
change.insert(data.pos, txt);
QTextCursor cursor(data.doc);
change.apply(&cursor);
data.pos += txt.length();
QStringList completions = getCompletions(data);
QCOMPARE(completions.size(), 2);
QVERIFY(completions.contains(QLatin1String("OtherType")));
QVERIFY(completions.contains(QLatin1String("otherTypeMember")));
}
void CppToolsPlugin::test_completion_local_type_and_member_4()
{
TestData data;
data.srcText =
"namespace NS {struct OtherType { int otherTypeMember; };}\n"
"void foo()\n"
"{\n"
" struct LocalType\n"
" {\n"
" int localTypeMember;\n"
" NS::OtherType ot;\n"
" };\n"
" LocalType lt;\n"
" @\n"
" // padding so we get the scope right\n"
"}\n"
;
setup(&data);
Utils::ChangeSet change;
QString txt = QLatin1String("lt.ot.");
change.insert(data.pos, txt);
QTextCursor cursor(data.doc);
change.apply(&cursor);
data.pos += txt.length();
QStringList completions = getCompletions(data);
QCOMPARE(completions.size(), 2);
QVERIFY(completions.contains(QLatin1String("OtherType")));
QVERIFY(completions.contains(QLatin1String("otherTypeMember")));
}
void CppToolsPlugin::test_completion_local_type_and_member_5()
{
TestData data;
data.srcText =
"namespace NS {struct OtherType { int otherTypeMember; };}\n"
"void foo()\n"
"{\n"
" using namespace NS;\n"
" struct LocalType\n"
" {\n"
" int localTypeMember;\n"
" OtherType ot;\n"
" };\n"
" LocalType lt;\n"
" @\n"
" // padding so we get the scope right\n"
"}\n"
;
setup(&data);
Utils::ChangeSet change;
QString txt = QLatin1String("lt.ot.");
change.insert(data.pos, txt);
QTextCursor cursor(data.doc);
change.apply(&cursor);
data.pos += txt.length();
QStringList completions = getCompletions(data);
QCOMPARE(completions.size(), 2);
QVERIFY(completions.contains(QLatin1String("OtherType")));
QVERIFY(completions.contains(QLatin1String("otherTypeMember")));
}
void CppToolsPlugin::test_completion_local_type_and_member_6()
{
TestData data;
data.srcText =
"namespace NS {struct OtherType { int otherTypeMember; };}\n"
"void foo()\n"
"{\n"
" using NS::OtherType;\n"
" struct LocalType\n"
" {\n"
" int localTypeMember;\n"
" OtherType ot;\n"
" };\n"
" LocalType lt;\n"
" @\n"
" // padding so we get the scope right\n"
"}\n"
;
setup(&data);
Utils::ChangeSet change;
QString txt = QLatin1String("lt.ot.");
change.insert(data.pos, txt);
QTextCursor cursor(data.doc);
change.apply(&cursor);
data.pos += txt.length();
QStringList completions = getCompletions(data);
QCOMPARE(completions.size(), 2);
QVERIFY(completions.contains(QLatin1String("OtherType")));
QVERIFY(completions.contains(QLatin1String("otherTypeMember")));
}

7
src/plugins/cpptools/cpptoolsplugin.h
View File

@@ -163,6 +163,13 @@ private slots:
void test_completion_lambdaCalls_4();
void test_completion_lambdaCalls_5();
void test_completion_local_type_and_member_1();
void test_completion_local_type_and_member_2();
void test_completion_local_type_and_member_3();
void test_completion_local_type_and_member_4();
void test_completion_local_type_and_member_5();
void test_completion_local_type_and_member_6();
void test_format_pointerdeclaration_in_simpledeclarations();
void test_format_pointerdeclaration_in_simpledeclarations_data();
void test_format_pointerdeclaration_in_controlflowstatements();