feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlJSEditor: Avoid detaching of containers

Browse Source 
Change-Id: I52bb5b073793c11cf157cb72244ba3552ca1ac72
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
This commit is contained in:
Christian Stenger
2018-01-22 12:23:09 +01:00
parent e8d7a1f21e
commit 3e81fe628a
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/qmljseditor/qmljseditordocument.cpp
View File

@@ -43,6 +43,8 @@
#include <qmljstools/qmljsmodelmanager.h> #include <qmljstools/qmljsmodelmanager.h>
#include <qmljstools/qmljsqtstylecodeformatter.h> #include <qmljstools/qmljsqtstylecodeformatter.h>
#include <utils/asconst.h>
using namespace QmlJSEditor; using namespace QmlJSEditor;
using namespace QmlJS; using namespace QmlJS;
using namespace QmlJS::AST; using namespace QmlJS::AST;
@@ -625,13 +627,13 @@ void QmlJSEditorDocumentPrivate::createTextMarks(const SemanticInfo &info)
m_semanticMarks.removeAll(mark); m_semanticMarks.removeAll(mark);
delete mark; delete mark;
}; };
for (const DiagnosticMessage &diagnostic : info.semanticMessages) { for (const DiagnosticMessage &diagnostic : Utils::asConst(info.semanticMessages)) {
auto mark = new QmlJSTextMark(q->filePath().toString(), auto mark = new QmlJSTextMark(q->filePath().toString(),
diagnostic, onMarkRemoved); diagnostic, onMarkRemoved);
m_semanticMarks.append(mark); m_semanticMarks.append(mark);
q->addMark(mark); q->addMark(mark);
} }
for (const QmlJS::StaticAnalysis::Message &message : info.staticAnalysisMessages) { for (const QmlJS::StaticAnalysis::Message &message : Utils::asConst(info.staticAnalysisMessages)) {
auto mark = new QmlJSTextMark(q->filePath().toString(), auto mark = new QmlJSTextMark(q->filePath().toString(),
message, onMarkRemoved); message, onMarkRemoved);
m_semanticMarks.append(mark); m_semanticMarks.append(mark);