feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

BareMetalRunConfigurationFactory: remove availableCreators reimp

Browse Source 
The base version adds "(on $devicename)" which is even more information
than the generic "(on GDB server or hardware debugger)" here.

If the  bti.projectFilePath extra path bits are needed, the feature
could be made generally available in the base implementation.

Also fix a typo in the BareMetalCustomRunConfiguration title

Change-Id: I293e36c7edd2a9459e29a7025ca5bb19fb39b4b0
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2018-03-13 11:18:22 +01:00
parent c26767e73c
commit 3f86d55587
2 changed files with 1 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/baremetal/baremetalrunconfigurationfactory.cpp
View File

@@ -46,18 +46,10 @@ BareMetalRunConfigurationFactory::BareMetalRunConfigurationFactory()
addSupportedTargetDeviceType(BareMetal::Constants::BareMetalOsType); addSupportedTargetDeviceType(BareMetal::Constants::BareMetalOsType);
} }
QList<RunConfigurationCreationInfo> BareMetalRunConfigurationFactory::availableCreators(Target *parent) const
{
return Utils::transform(parent->applicationTargets().list, [this](const BuildTargetInfo &bti) {
return convert(tr("%1 (on GDB server or hardware debugger)").arg(QFileInfo(bti.targetName).fileName()),
bti.projectFilePath.toString() + '/' + bti.targetName);
});
}
// BareMetalCustomRunConfigurationFactory // BareMetalCustomRunConfigurationFactory
BareMetalCustomRunConfigurationFactory::BareMetalCustomRunConfigurationFactory() : BareMetalCustomRunConfigurationFactory::BareMetalCustomRunConfigurationFactory() :
FixedRunConfigurationFactory(BareMetalCustomRunConfiguration::tr("Custom Executable)"), true) FixedRunConfigurationFactory(BareMetalCustomRunConfiguration::tr("Custom Executable"), true)
{ {
registerRunConfiguration<BareMetalCustomRunConfiguration>("BareMetal.CustomRunConfig"); registerRunConfiguration<BareMetalCustomRunConfiguration>("BareMetal.CustomRunConfig");
addSupportedTargetDeviceType(BareMetal::Constants::BareMetalOsType); addSupportedTargetDeviceType(BareMetal::Constants::BareMetalOsType);

3
src/plugins/baremetal/baremetalrunconfigurationfactory.h
View File

@@ -36,9 +36,6 @@ class BareMetalRunConfigurationFactory : public ProjectExplorer::RunConfiguratio
public: public:
BareMetalRunConfigurationFactory(); BareMetalRunConfigurationFactory();
QList<ProjectExplorer::RunConfigurationCreationInfo>
availableCreators(ProjectExplorer::Target *parent) const override;
}; };
class BareMetalCustomRunConfigurationFactory : public ProjectExplorer::FixedRunConfigurationFactory class BareMetalCustomRunConfigurationFactory : public ProjectExplorer::FixedRunConfigurationFactory