feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Don't re-check pending LLDB breakpoints

Browse Source 
This partially reverts change 1d1695c2.

This doesn't seem to be needed with recent versions of LLDB anymore
and removes one source of "spurious" breakpoint-changed events.

Change-Id: I8140944a46bbc83173c0088117a88110b0872e8a
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This commit is contained in:
hjk
2015-02-24 09:13:12 +01:00
parent 8b17f10cd4
commit 4198cc1441
1 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
share/qtcreator/debugger/lldbbridge.py
View File

@@ -228,7 +228,6 @@ class Dumper(DumperBase):
self.isShuttingDown_ = False self.isShuttingDown_ = False
self.isInterrupting_ = False self.isInterrupting_ = False
self.dummyValue = None self.dummyValue = None
self.breakpointsToCheck = set([])
self.qmlBreakpointResolvers = {} self.qmlBreakpointResolvers = {}
self.qmlTriggeredBreakpoint = None self.qmlTriggeredBreakpoint = None
@@ -796,14 +795,6 @@ class Dumper(DumperBase):
result += '],current-thread-id="%s"},' % self.currentThread().id result += '],current-thread-id="%s"},' % self.currentThread().id
self.report(result) self.report(result)
def reportChangedBreakpoints(self):
for i in xrange(0, self.target.GetNumBreakpoints()):
bp = self.target.GetBreakpointAtIndex(i)
if bp.GetID() in self.breakpointsToCheck:
if bp.GetNumLocations():
self.breakpointsToCheck.remove(bp.GetID())
self.report('breakpoint-changed={%s}' % self.describeBreakpoint(bp))
def firstUsableFrame(self, thread): def firstUsableFrame(self, thread):
for i in xrange(10): for i in xrange(10):
frame = thread.GetFrameAtIndex(i) frame = thread.GetFrameAtIndex(i)
@@ -1325,7 +1316,6 @@ class Dumper(DumperBase):
self.reportStackTop() self.reportStackTop()
self.reportThreads() self.reportThreads()
self.reportLocation() self.reportLocation()
self.reportChangedBreakpoints()
elif eventType == lldb.SBProcess.eBroadcastBitInterrupt: # 2 elif eventType == lldb.SBProcess.eBroadcastBitInterrupt: # 2
pass pass
elif eventType == lldb.SBProcess.eBroadcastBitSTDOUT: elif eventType == lldb.SBProcess.eBroadcastBitSTDOUT:
@@ -1441,7 +1431,6 @@ class Dumper(DumperBase):
bp.SetEnabled(int(args["enabled"])) bp.SetEnabled(int(args["enabled"]))
if hasattr(bp, 'SetOneShot'): if hasattr(bp, 'SetOneShot'):
bp.SetOneShot(int(args["oneshot"])) bp.SetOneShot(int(args["oneshot"]))
self.breakpointsToCheck.add(bp.GetID())
self.report('breakpoint-added={%s,modelid="%s"}' % (self.describeBreakpoint(bp), modelId)) self.report('breakpoint-added={%s,modelid="%s"}' % (self.describeBreakpoint(bp), modelId))
def changeBreakpoint(self, args): def changeBreakpoint(self, args):