feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

DockerDevice: Connect to QtcProcess::done() signal

Browse Source 
Instead of connecting to errorOccurred() and finished() signals.

Change-Id: I0dd1d35aa48bfb7769623ff5735a7abd644d180f
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2022-04-06 09:42:48 +02:00
parent ca480ec601
commit 4762d54401
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/docker/dockerdevice.cpp
View File

@@ -273,13 +273,12 @@ DockerDevice::DockerDevice(const DockerDeviceData &data)
return; return;
} }
QtcProcess *proc = new QtcProcess; QtcProcess *proc = new QtcProcess(d);
proc->setTerminalMode(TerminalMode::On); proc->setTerminalMode(TerminalMode::On);
QObject::connect(proc, &QtcProcess::finished, proc, &QObject::deleteLater); QObject::connect(proc, &QtcProcess::done, [proc] {
if (proc->error() != QProcess::UnknownError && MessageManager::instance())
QObject::connect(proc, &QtcProcess::errorOccurred, [proc] { MessageManager::writeDisrupting(tr("Error starting remote shell."));
MessageManager::writeDisrupting(tr("Error starting remote shell."));
proc->deleteLater(); proc->deleteLater();
}); });