feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LanguageClient: Don't needlessly store empty values

Browse Source 
Task-number: QTCREATORBUG-24762
Change-Id: Ifdff1e3cd23ce287b0c7a17064587e995616d42f
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Marcus Tillmanns
2024-01-31 11:11:18 +01:00
parent 20904b2411
commit 4aab6a9173
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/languageclient/languageclientsettings.cpp
View File

@@ -664,7 +664,9 @@ void LanguageClientSettings::toSettings(QtcSettings *settings,
auto isStdioSetting = Utils::equal(&BaseSettings::m_settingsTypeId, auto isStdioSetting = Utils::equal(&BaseSettings::m_settingsTypeId,
Utils::Id(Constants::LANGUAGECLIENT_STDIO_SETTINGS_ID)); Utils::Id(Constants::LANGUAGECLIENT_STDIO_SETTINGS_ID));
auto [stdioSettings, typedSettings] = Utils::partition(languageClientSettings, isStdioSetting); auto [stdioSettings, typedSettings] = Utils::partition(languageClientSettings, isStdioSetting);
if (!stdioSettings.isEmpty())
settings->setValue(clientsKey, transform(stdioSettings)); settings->setValue(clientsKey, transform(stdioSettings));
if (!typedSettings.isEmpty())
settings->setValue(typedClientsKey, transform(typedSettings)); settings->setValue(typedClientsKey, transform(typedSettings));
settings->endGroup(); settings->endGroup();
} }