feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Qnx: Remove unused commandFound() method

Browse Source 
Task-number: QTCREATORBUG-29168
Change-Id: Ifad415adfcfa06f6152d39112e576bdc18487a6b
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2024-11-18 14:15:50 +01:00
parent bf111451cd
commit 4bddce64f5
2 changed files with 1 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/qnx/slog2inforunner.cpp
View File

@@ -38,10 +38,6 @@ void Slog2InfoRunner::start()
process.setCommand(CommandLine{device()->filePath("slog2info")}); process.setCommand(CommandLine{device()->filePath("slog2info")});
}; };
const auto onTestDone = [this](DoneWith result) { const auto onTestDone = [this](DoneWith result) {
if (result == DoneWith::Success) {
m_found = true;
return;
}
appendMessage(Tr::tr("Warning: \"slog2info\" is not found on the device, " appendMessage(Tr::tr("Warning: \"slog2info\" is not found on the device, "
"debug output not available."), ErrorMessageFormat); "debug output not available."), ErrorMessageFormat);
}; };
@@ -51,7 +47,6 @@ void Slog2InfoRunner::start()
}; };
const auto onLaunchTimeDone = [this](const Process &process) { const auto onLaunchTimeDone = [this](const Process &process) {
QTC_CHECK(!m_applicationId.isEmpty()); QTC_CHECK(!m_applicationId.isEmpty());
QTC_CHECK(m_found);
m_launchDateTime = QDateTime::fromString(process.cleanedStdOut().trimmed(), "dd HH:mm:ss"); m_launchDateTime = QDateTime::fromString(process.cleanedStdOut().trimmed(), "dd HH:mm:ss");
}; };
@@ -70,7 +65,7 @@ void Slog2InfoRunner::start()
}; };
const Group root { const Group root {
ProcessTask(onTestSetup, onTestDone), ProcessTask(onTestSetup, onTestDone, CallDoneIf::Error),
ProcessTask(onLaunchTimeSetup, onLaunchTimeDone, CallDoneIf::Success), ProcessTask(onLaunchTimeSetup, onLaunchTimeDone, CallDoneIf::Success),
ProcessTask(onLogSetup, onLogError, CallDoneIf::Error) ProcessTask(onLogSetup, onLogError, CallDoneIf::Error)
}; };
@@ -86,11 +81,6 @@ void Slog2InfoRunner::stop()
reportStopped(); reportStopped();
} }
bool Slog2InfoRunner::commandFound() const
{
return m_found;
}
void Slog2InfoRunner::processRemainingLogData() void Slog2InfoRunner::processRemainingLogData()
{ {
if (!m_remainingData.isEmpty()) if (!m_remainingData.isEmpty())

5
src/plugins/qnx/slog2inforunner.h
View File

@@ -19,20 +19,15 @@ public:
void start() override; void start() override;
void stop() override; void stop() override;
bool commandFound() const;
private: private:
void processRemainingLogData(); void processRemainingLogData();
void processLogInput(const QString &input); void processLogInput(const QString &input);
void processLogLine(const QString &line); void processLogLine(const QString &line);
QString m_applicationId; QString m_applicationId;
QDateTime m_launchDateTime; QDateTime m_launchDateTime;
bool m_found = false;
bool m_currentLogs = false; bool m_currentLogs = false;
QString m_remainingData; QString m_remainingData;
Tasking::TaskTreeRunner m_taskTreeRunner; Tasking::TaskTreeRunner m_taskTreeRunner;
}; };