QmlDesigner: fix uninitialzed value warnings

Change-Id: Ieddd83953b2009656ceecea2f9fedecd54ac9ac8
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

share/qtcreator/qml/qmlpuppet/container/instancecontainer.cpp

@@ -41,7 +41,6 @@ static TypeName properDelemitingOfType(const TypeName &typeName)
 }
 
 InstanceContainer::InstanceContainer()
-    : m_instanceId(-1), m_majorNumber(-1), m_minorNumber(-1)
 {
 }
 

share/qtcreator/qml/qmlpuppet/container/instancecontainer.h

@@ -67,14 +67,14 @@ public:
     NodeMetaType metaType() const;
 
 private:
-    qint32 m_instanceId;
+    qint32 m_instanceId = -1;
     TypeName m_type;
-    qint32 m_majorNumber;
-    qint32 m_minorNumber;
+    qint32 m_majorNumber = -1;
+    qint32 m_minorNumber = -1;
     QString m_componentPath;
     QString m_nodeSource;
-    qint32 m_nodeSourceType;
-    qint32 m_metaType;
+    qint32 m_nodeSourceType = 0;
+    qint32 m_metaType = 0;
 };
 
 QDebug operator <<(QDebug debug, const InstanceContainer &command);

src/plugins/qmldesigner/components/componentcore/findimplementation.cpp

@@ -231,7 +231,7 @@ private:
 
     QString m_typeName;
     QString m_itemId;
-    const ObjectValue *m_typeValue;
+    const ObjectValue *m_typeValue = nullptr;
     bool m_insideObject = false;
 };
 

src/plugins/qmldesigner/components/componentcore/selectioncontext.cpp

@@ -30,15 +30,13 @@
 namespace QmlDesigner {
 
 
-SelectionContext::SelectionContext() :
-    m_toggled(false)
+SelectionContext::SelectionContext()
 {
 
 }
 
 SelectionContext::SelectionContext(AbstractView *view) :
-    m_view(view),
-    m_toggled(false)
+    m_view(view)
 {
 }
 

src/plugins/qmldesigner/components/componentcore/selectioncontext.h

@@ -65,9 +65,9 @@ public:
 private:
     QPointer<AbstractView> m_view;
     ModelNode m_targetNode;
-    bool m_showSelectionTools;
+    bool m_showSelectionTools = false;
     QPointF m_scenePosition;
-    bool m_toggled;
+    bool m_toggled = false;
 };
 
 } //QmlDesigner

src/plugins/qmldesigner/components/formeditor/anchorindicatorgraphicsitem.h

@@ -57,8 +57,8 @@ private:
     QPointF m_sourceAnchorLineSecondPoint;
     QPointF m_targetAnchorLineFirstPoint;
     QPointF m_targetAnchorLineSecondPoint;
-    AnchorLineType m_sourceAnchorLineType;
-    AnchorLineType m_targetAnchorLineType;
+    AnchorLineType m_sourceAnchorLineType = AnchorLineInvalid;
+    AnchorLineType m_targetAnchorLineType = AnchorLineInvalid;
     QRectF m_boundingRect;
 };
 

src/plugins/qmldesigner/designercore/filemanager/astobjecttextextractor.h

@@ -45,7 +45,7 @@ protected:
 
 private:
     QmlJS::Document::MutablePtr m_document;
-    quint32 m_location;
+    quint32 m_location = 0;
     QString m_text;
 };
 

src/plugins/qmldesigner/designercore/filemanager/firstdefinitionfinder.h

@@ -48,7 +48,7 @@ protected:
 private:
     QmlJS::Document::MutablePtr m_doc;
     quint32 m_offset;
-    QmlJS::AST::UiObjectDefinition *m_firstObjectDefinition;
+    QmlJS::AST::UiObjectDefinition *m_firstObjectDefinition = nullptr;
 
 };
 

src/plugins/qmldesigner/designercore/filemanager/moveobjectbeforeobjectvisitor.h

@@ -67,8 +67,8 @@ private:
     bool toEnd;
     quint32 beforeObjectLocation;
 
-    QmlJS::AST::UiObjectDefinition *movingObject;
-    QmlJS::AST::UiObjectDefinition *beforeObject;
+    QmlJS::AST::UiObjectDefinition *movingObject = nullptr;
+    QmlJS::AST::UiObjectDefinition *beforeObject = nullptr;
     ASTPath movingObjectParents;
 };
 

src/plugins/qmldesigner/designercore/filemanager/objectlengthcalculator.h

@@ -45,8 +45,8 @@ protected:
 
 private:
     QmlJS::Document::MutablePtr m_doc;
-    quint32 m_offset;
-    quint32 m_length;
+    quint32 m_offset = 0;
+    quint32 m_length = 0;
 };
 
 } // namespace QmlDesigner

src/plugins/qmldesigner/designercore/include/nodeinstanceview.h

@@ -193,7 +193,6 @@ private: //variables
     QHash<ModelNode, NodeInstance> m_nodeInstanceHash;
     QHash<ModelNode, QImage> m_statePreviewImage;
 
-    uint m_blockUpdates;
     QPointer<NodeInstanceServerInterface> m_nodeInstanceServer;
     QImage m_baseStatePreviewImage;
     QTime m_lastCrashTime;

src/plugins/qmldesigner/designercore/model/internalnode_p.h

@@ -150,7 +150,7 @@ private:
     QStringList m_scriptFunctionList;
 
     QString m_nodeSource;
-    int m_nodeSourceType;
+    int m_nodeSourceType = 0;
 };
 
 uint qHash(const InternalNodePointer& node);

src/plugins/qmldesigner/designercore/rewritertransaction.h

@@ -54,7 +54,7 @@ private:
    QPointer<AbstractView> m_view;
    QByteArray m_identifier;
    mutable bool m_valid;
-   int m_identifierNumber;
+   int m_identifierNumber = 0;
    static QList<QByteArray> m_identifierList;
    static bool m_activeIdentifier;
    bool m_ignoreSemanticChecks = false;