feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Fix crash

Browse Source 
If the target cannot be resolved the result is invalid.

Task-number: QDS-5216
Change-Id: Ibd7884d6638ae653953347862ca1291f963aa3b3
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
This commit is contained in:
Thomas Hartmann
2021-10-05 10:29:32 +02:00
committed by Thomas Hartmann
parent 28b87ba4f4
commit 50557abd03
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/qmldesigner/components/stateseditor/stateseditorview.cpp
View File

@@ -46,6 +46,7 @@
#include <qmlstate.h> #include <qmlstate.h>
#include <annotationeditor/annotationeditor.h> #include <annotationeditor/annotationeditor.h>
#include <utils/algorithm.h> #include <utils/algorithm.h>
#include <utils/qtcassert.h>
namespace QmlDesigner { namespace QmlDesigner {
@@ -103,6 +104,7 @@ void StatesEditorView::removeState(int nodeId)
const auto propertyChanges = modelState.propertyChanges(); const auto propertyChanges = modelState.propertyChanges();
for (const QmlPropertyChanges &change : propertyChanges) { for (const QmlPropertyChanges &change : propertyChanges) {
const ModelNode target = change.target(); const ModelNode target = change.target();
QTC_ASSERT(target.isValid(), continue);
if (target.locked()) if (target.locked())
lockedTargets.push_back(target.id()); lockedTargets.push_back(target.id());
} }