feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify some TaskHandler::canHandle() implementations

Browse Source 
Change-Id: I957b40b8e920818a7dadf1d3edc01dc5ab8d2077
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2025-06-16 16:52:50 +02:00
parent dfbd0f56e3
commit 53d3ae80c8
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/projectexplorer/taskhandlers.cpp
View File

@@ -196,10 +196,7 @@ private:
bool canHandle(const Task &task) const override bool canHandle(const Task &task) const override
{ {
if (task.file.isEmpty()) return task.file.isReadableFile();
return false;
QFileInfo fi(task.file.toFileInfo());
return fi.exists() && fi.isFile() && fi.isReadable();
} }
void handle(const Task &task) override void handle(const Task &task) override
@@ -227,8 +224,7 @@ public:
private: private:
bool canHandle(const Task &task) const override bool canHandle(const Task &task) const override
{ {
QFileInfo fi(task.file.toFileInfo()); if (!task.file.isReadableFile())
if (!fi.exists() || !fi.isFile() || !fi.isReadable())
return false; return false;
IVersionControl *vc = VcsManager::findVersionControlForDirectory(task.file.absolutePath()); IVersionControl *vc = VcsManager::findVersionControlForDirectory(task.file.absolutePath());
if (!vc) if (!vc)