feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectConfigurationModel: Avoid using sender()

Browse Source 
Change-Id: I65a2da1f2e8a5d3bb98bda752942d83e4074df9d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Jarek Kobus
2022-07-20 16:31:55 +02:00
parent 240105f55f
commit 5434ea417f
2 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/projectexplorer/projectconfigurationmodel.cpp
View File

@@ -64,12 +64,8 @@ int ProjectConfigurationModel::columnCount(const QModelIndex &parent) const
return parent.isValid() ? 0 : 1; return parent.isValid() ? 0 : 1;
} }
void ProjectConfigurationModel::displayNameChanged() void ProjectConfigurationModel::displayNameChanged(ProjectConfiguration *pc)
{ {
auto pc = qobject_cast<ProjectConfiguration *>(sender());
if (!pc)
return;
// Find the old position // Find the old position
int oldPos = m_projectConfigurations.indexOf(pc); int oldPos = m_projectConfigurations.indexOf(pc);
if (oldPos < 0) if (oldPos < 0)
@@ -148,7 +144,7 @@ void ProjectConfigurationModel::addProjectConfiguration(ProjectConfiguration *pc
endInsertRows(); endInsertRows();
connect(pc, &ProjectConfiguration::displayNameChanged, connect(pc, &ProjectConfiguration::displayNameChanged,
this, &ProjectConfigurationModel::displayNameChanged); this, [this, pc] { displayNameChanged(pc); });
} }
void ProjectConfigurationModel::removeProjectConfiguration(ProjectConfiguration *pc) void ProjectConfigurationModel::removeProjectConfiguration(ProjectConfiguration *pc)

2
src/plugins/projectexplorer/projectconfigurationmodel.h
View File

@@ -52,7 +52,7 @@ public:
void removeProjectConfiguration(ProjectConfiguration *pc); void removeProjectConfiguration(ProjectConfiguration *pc);
private: private:
void displayNameChanged(); void displayNameChanged(ProjectConfiguration *pc);
Target *m_target; Target *m_target;
QList<ProjectConfiguration *> m_projectConfigurations; QList<ProjectConfiguration *> m_projectConfigurations;