feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangCodeModel: Remove inapplicable TODO item

Browse Source 
It's not worth the extra effort to restrict the identifier <-> file name
check to data types: There is hardly any possibility for a completely
false positive, as local variables do not pass through this code path.

Change-Id: Ia92549c8c6723e520789a2ad820a2606620d4efe
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Kandeler
2021-09-24 13:11:31 +02:00
parent eefc8cbc7d
commit 553f4bec7e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/clangcodemodel/clangdclient.cpp
View File

@@ -1230,7 +1230,7 @@ void ClangdClient::Private::addSearchResultsForFile(ReferencesData &refData,
if (fileInSession && file.baseName().compare( if (fileInSession && file.baseName().compare(
refData.replacementData->oldSymbolName, refData.replacementData->oldSymbolName,
Qt::CaseInsensitive) == 0) { Qt::CaseInsensitive) == 0) {
refData.replacementData->fileRenameCandidates << file; // TODO: We want to do this only for types. Use SymbolInformation once we have it. refData.replacementData->fileRenameCandidates << file;
} }
} }
items << item; items << item;