feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Vcs plugins: Replace foreach with ranged for loop

Browse Source 
Change-Id: I9be29ef128f49f62a6e1f450d8c5277b467310e9
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2022-09-30 16:34:09 +02:00
parent 8640e00447
commit 55efe40a58
5 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/bazaar/bazaarplugin.cpp
View File

@@ -834,7 +834,8 @@ bool BazaarPluginPrivate::submitEditorAboutToClose()
if (!commitWidget->committer().isEmpty())
extraOptions.append(QLatin1String("--author=") + commitWidget->committer());
// Fixed bugs
foreach (const QString &fix, commitWidget->fixedBugs()) {
const QStringList fixes = commitWidget->fixedBugs();
for (const QString &fix : fixes) {
if (!fix.isEmpty())
extraOptions << QLatin1String("--fixes") << fix;
}
@@ -864,7 +865,7 @@ void BazaarPluginPrivate::updateActions(VcsBasePluginPrivate::ActionState as)
m_revertFile->setParameter(filename);
m_statusFile->setParameter(filename);
foreach (QAction *repoAction, m_repositoryActionList)
for (QAction *repoAction : qAsConst(m_repositoryActionList))
repoAction->setEnabled(repoEnabled);
}

8
src/plugins/bazaar/commiteditor.cpp
View File

@@ -26,9 +26,9 @@ BazaarCommitWidget *CommitEditor::commitWidget()
return static_cast<BazaarCommitWidget *>(widget());
}
void CommitEditor::setFields(const QString &repositoryRoot,
const BranchInfo &branch, const QString &userName,
const QString &email, const QList<VcsBase::VcsBaseClient::StatusItem> &repoStatus)
void CommitEditor::setFields(const QString &repositoryRoot, const BranchInfo &branch,
const QString &userName, const QString &email,
const QList<VcsBase::VcsBaseClient::StatusItem> &repoStatus)
{
BazaarCommitWidget *bazaarWidget = commitWidget();
if (!bazaarWidget)
@@ -50,7 +50,7 @@ void CommitEditor::setFields(const QString &repositoryRoot,
return VcsBase::SubmitFileModel::FileStatusUnknown;
} );
foreach (const VcsBase::VcsBaseClient::StatusItem &item, repoStatus)
for (const VcsBase::VcsBaseClient::StatusItem &item : repoStatus)
if (item.flags != QLatin1String("Unknown"))
m_fileModel->addFile(item.file, item.flags);
setFileModel(m_fileModel);

2
src/plugins/clearcase/clearcasesync.cpp
View File

@@ -126,7 +126,7 @@ void ClearCaseSync::updateTotalFilesCount(const QString &view, ClearCaseSettings
void ClearCaseSync::updateStatusForNotManagedFiles(const QStringList &files)
{
foreach (const QString &file, files) {
for (const QString &file : files) {
QString absFile = QFileInfo(file).absoluteFilePath();
if (!m_statusMap->contains(absFile))
ClearCasePlugin::setStatus(absFile, FileStatus::NotManaged, false);

2
src/plugins/cvs/cvsutils.cpp
View File

@@ -160,7 +160,7 @@ StateList parseStatusOutput(const QString &directory, const QString &output)
QString path = directory;
if (!path.isEmpty())
path += slash;
foreach (const QString &l, list) {
for (const QString &l : list) {
// Status line containing file
if (l.startsWith(fileKeyword)) {
// Parse state

4
src/plugins/subversion/subversionplugin.cpp
View File

@@ -129,7 +129,7 @@ StatusList parseStatusOutput(const QString &output)
StatusList changeSet;
const QString newLine = QString(QLatin1Char('\n'));
const QStringList list = output.split(newLine, Qt::SkipEmptyParts);
foreach (const QString &l, list) {
for (const QString &l : list) {
const QString line =l.trimmed();
if (line.size() > 8) {
const QByteArray state = line.left(1).toLatin1();
@@ -1039,7 +1039,7 @@ QString SubversionPluginPrivate::monitorFile(const FilePath &repository) const
{
QTC_ASSERT(!repository.isEmpty(), return QString());
QDir repoDir(repository.toString());
foreach (const QString &svnDir, m_svnDirectories) {
for (const QString &svnDir : qAsConst(m_svnDirectories)) {
if (repoDir.exists(svnDir)) {
QFileInfo fi(repoDir.absoluteFilePath(svnDir + QLatin1String("/wc.db")));
if (fi.exists() && fi.isFile())