feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Devirtualize some methods

Browse Source 
There are no subclasses of DataModel and CallModel,
so no need to have virtual methods.

Change-Id: Ibce461bba2e80e491844aaaf1593efdcf03f3a9e
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2024-10-04 09:13:16 +02:00
parent 83e471df98
commit 5954f9ba16
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/valgrind/callgrind/callgrindcallmodel.h
View File

@@ -26,11 +26,11 @@ public:
/// Only one cost event column will be shown, this decides which one it is. /// Only one cost event column will be shown, this decides which one it is.
/// By default it is the first event in the @c ParseData, i.e. 0. /// By default it is the first event in the @c ParseData, i.e. 0.
virtual int costEvent() const; int costEvent() const;
virtual void setCostEvent(int event); void setCostEvent(int event);
virtual void setParseData(const ParseData *data); void setParseData(const ParseData *data);
virtual const ParseData *parseData() const; const ParseData *parseData() const;
void setCalls(const QList<const FunctionCall *> &calls, const Function *function); void setCalls(const QList<const FunctionCall *> &calls, const Function *function);
QList<const FunctionCall *> calls() const; QList<const FunctionCall *> calls() const;

8
src/plugins/valgrind/callgrind/callgrinddatamodel.h
View File

@@ -20,15 +20,15 @@ public:
DataModel(); DataModel();
~DataModel() override; ~DataModel() override;
virtual void setParseData(const ParseData *data); void setParseData(const ParseData *data);
virtual const ParseData *parseData() const; const ParseData *parseData() const;
void setVerboseToolTipsEnabled(bool enabled); void setVerboseToolTipsEnabled(bool enabled);
bool verboseToolTipsEnabled() const; bool verboseToolTipsEnabled() const;
/// Only one cost event column will be shown, this decides which one it is. /// Only one cost event column will be shown, this decides which one it is.
/// By default it is the first event in the @c ParseData, i.e. 0. /// By default it is the first event in the @c ParseData, i.e. 0.
virtual int costEvent() const; int costEvent() const;
int rowCount(const QModelIndex &parent = QModelIndex()) const override; int rowCount(const QModelIndex &parent = QModelIndex()) const override;
int columnCount(const QModelIndex &parent = QModelIndex()) const override; int columnCount(const QModelIndex &parent = QModelIndex()) const override;
@@ -61,7 +61,7 @@ public:
/// Only one cost event column will be shown, this decides which one it is. /// Only one cost event column will be shown, this decides which one it is.
/// By default it is the first event in the @c ParseData, i.e. 0. /// By default it is the first event in the @c ParseData, i.e. 0.
virtual void setCostEvent(int event); void setCostEvent(int event);
private: private:
class Private; class Private;