feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: remove unnecessary save method

Browse Source 
Change-Id: Ia2a195c84ce83bc3a83155cc19b0585475a5547a
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Tim Jenssen
2016-12-23 16:13:14 +01:00
parent 2ea7119b69
commit 5ad0cbc070
3 changed files with 1 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/qmldesigner/designercore/include/plaintexteditmodifier.h
View File

@@ -49,8 +49,6 @@ public:
PlainTextEditModifier(QPlainTextEdit *textEdit); PlainTextEditModifier(QPlainTextEdit *textEdit);
~PlainTextEditModifier(); ~PlainTextEditModifier();
virtual void save(QIODevice *device);
QTextDocument *textDocument() const override; QTextDocument *textDocument() const override;
QString text() const override; QString text() const override;
QTextCursor textCursor() const override; QTextCursor textCursor() const override;

5
src/plugins/qmldesigner/designercore/model/plaintexteditmodifier.cpp
View File

@@ -52,11 +52,6 @@ PlainTextEditModifier::~PlainTextEditModifier()
{ {
} }
void PlainTextEditModifier::save(QIODevice *device)
{
device->write(m_textEdit->toPlainText().toUtf8());
}
void PlainTextEditModifier::replace(int offset, int length, const QString &replacement) void PlainTextEditModifier::replace(int offset, int length, const QString &replacement)
{ {
#if 0 #if 0

8
tests/auto/qml/qmldesigner/coretests/tst_testcore.cpp
View File

@@ -380,11 +380,6 @@ void tst_TestCore::saveEmptyCoreModel()
testRewriterView1->setTextModifier(&modifier1); testRewriterView1->setTextModifier(&modifier1);
model1->attachView(testRewriterView1.data()); model1->attachView(testRewriterView1.data());
QBuffer buffer;
buffer.open(QIODevice::ReadWrite | QIODevice::Text);
modifier1.save(&buffer);
QPlainTextEdit textEdit2; QPlainTextEdit textEdit2;
textEdit2.setPlainText("import QtQuick 1.1; Item{}"); textEdit2.setPlainText("import QtQuick 1.1; Item{}");
NotIndentingTextEditModifier modifier2(&textEdit2); NotIndentingTextEditModifier modifier2(&textEdit2);
@@ -396,7 +391,6 @@ void tst_TestCore::saveEmptyCoreModel()
model2->attachView(testRewriterView2.data()); model2->attachView(testRewriterView2.data());
QVERIFY(compareTree(testRewriterView1->rootModelNode(), testRewriterView2->rootModelNode())); QVERIFY(compareTree(testRewriterView1->rootModelNode(), testRewriterView2->rootModelNode()));
} }
void tst_TestCore::loadAttributesInCoreModel() void tst_TestCore::loadAttributesInCoreModel()
@@ -453,7 +447,7 @@ void tst_TestCore::saveAttributesInCoreModel()
QBuffer buffer; QBuffer buffer;
buffer.open(QIODevice::ReadWrite | QIODevice::Text); buffer.open(QIODevice::ReadWrite | QIODevice::Text);
modifier1.save(&buffer); buffer.write(modifier1.textDocument()->toPlainText().toUtf8());
QPlainTextEdit textEdit2; QPlainTextEdit textEdit2;
textEdit2.setPlainText(QString::fromUtf8(buffer.data())); textEdit2.setPlainText(QString::fromUtf8(buffer.data()));