feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Forward declare QtcProcess instead of #include

Browse Source 
The QtcProcess is already forward declared in idevice.h.

In case of std::unique_ptr<MyClass> being a member
of a public class in a header file it's enough to
deinline constructor and destructor of a class
containing the member, and forward declare MyClass.

Amends f91a9cb891

Change-Id: Iacf272b62fed8827c0451c5d4c5c3429bb7106ef
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Jarek Kobus
2022-03-31 09:18:23 +02:00
parent 059d20ed22
commit 5b1035c20f
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/android/androidsignaloperation.cpp
View File

@@ -42,6 +42,8 @@ AndroidSignalOperation::AndroidSignalOperation()
connect(m_timeout, &QTimer::timeout, this, &AndroidSignalOperation::handleTimeout); connect(m_timeout, &QTimer::timeout, this, &AndroidSignalOperation::handleTimeout);
} }
AndroidSignalOperation::~AndroidSignalOperation() = default;
void AndroidSignalOperation::adbFindRunAsFinished() void AndroidSignalOperation::adbFindRunAsFinished()
{ {
QTC_ASSERT(m_state == RunAs, return); QTC_ASSERT(m_state == RunAs, return);

3
src/plugins/android/androidsignaloperation.h
View File

@@ -26,7 +26,6 @@
#pragma once #pragma once
#include <projectexplorer/devicesupport/idevice.h> #include <projectexplorer/devicesupport/idevice.h>
#include <utils/qtcprocess.h>
#include <QObject> #include <QObject>
#include <QTimer> #include <QTimer>
@@ -38,7 +37,7 @@ class AndroidSignalOperation : public ProjectExplorer::DeviceProcessSignalOperat
{ {
Q_OBJECT Q_OBJECT
public: public:
~AndroidSignalOperation() override = default; ~AndroidSignalOperation() override;
void killProcess(qint64 pid) override; void killProcess(qint64 pid) override;
void killProcess(const QString &filePath) override; void killProcess(const QString &filePath) override;
void interruptProcess(qint64 pid) override; void interruptProcess(qint64 pid) override;