feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Welcome: Detach Welcome page registration for global object pool

Browse Source 
We require individual pages to be provided in Plugin::initialize()

Change-Id: I431112b523ed4cc803c07e5c6df8aa8d4ed1663b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2018-01-25 14:33:14 +01:00
parent b16019c95b
commit 5e55c1e947
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/welcome/welcomeplugin.cpp
View File

@@ -356,12 +356,6 @@ void WelcomeMode::initPlugins()
for (IWelcomePage *page : IWelcomePage::allWelcomePages()) for (IWelcomePage *page : IWelcomePage::allWelcomePages())
addPage(page); addPage(page);
// make sure later added pages are made available too:
connect(PluginManager::instance(), &PluginManager::objectAdded, this, [this](QObject *obj) {
if (IWelcomePage *page = qobject_cast<IWelcomePage*>(obj))
addPage(page);
});
if (!m_activePage.isValid() && !m_pageButtons.isEmpty()) { if (!m_activePage.isValid() && !m_pageButtons.isEmpty()) {
m_activePage = m_pluginList.at(0)->id(); m_activePage = m_pluginList.at(0)->id();
m_pageButtons.at(0)->click(); m_pageButtons.at(0)->click();