feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix warning: "Don't call QList::front() on temporary"

Browse Source 
..using constFirst, instead.

[-Wclazy-detaching-temporary]

Change-Id: I66bd9c19d56dc5dcc7ee0a1f68f4bfd2a3af7326
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Alessandro Portale
2019-01-17 02:03:19 +01:00
parent adea8467f4
commit 5f5e82b0b6
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/vcsbase/vcsbasesubmiteditor.cpp
View File

@@ -624,7 +624,7 @@ void VcsBaseSubmitEditor::slotInsertNickName()
void VcsBaseSubmitEditor::slotSetFieldNickName(int i)
{
if (SubmitFieldWidget *sfw = d->m_widget->submitFieldWidgets().front()) {
if (SubmitFieldWidget *sfw = d->m_widget->submitFieldWidgets().constFirst()) {
const QString nick = promptForNickName();
if (!nick.isEmpty())
sfw->setFieldValue(i, nick);