feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectWindow: Remove dead code

Browse Source 
The ProjectWindow page gets all objects of type IProjectPanelFactory
from the object pool. Since ITargetPanelFactory is not derived from
IProjectPanelFactory, the removed qobject_cast can never work.

Change-Id: I52186e33e1992dc3556fcb2900719e9a8158da39
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Daniel Teske
2014-07-11 11:54:49 +02:00
parent d546c6c741
commit 611d0016dd
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/projectexplorer/projectwindow.cpp
View File

@@ -385,7 +385,7 @@ void ProjectWindow::showProperties(int index, int subIndex)
// Set up custom panels again: // Set up custom panels again:
int pos = 0; int pos = 0;
IPanelFactory *fac = 0; IProjectPanelFactory *fac = 0;
// remember previous sub index state of target settings page // remember previous sub index state of target settings page
if (TargetSettingsPanelWidget *previousPanelWidget if (TargetSettingsPanelWidget *previousPanelWidget
= qobject_cast<TargetSettingsPanelWidget*>(m_currentWidget)) { = qobject_cast<TargetSettingsPanelWidget*>(m_currentWidget)) {
@@ -421,11 +421,7 @@ void ProjectWindow::showProperties(int index, int subIndex)
if (fac) { if (fac) {
removeCurrentWidget(); removeCurrentWidget();
PropertiesPanel *panel = 0; PropertiesPanel *panel = fac->createPanel(project);
if (ITargetPanelFactory *ipf = qobject_cast<ITargetPanelFactory *>(fac))
panel = ipf->createPanel(project->activeTarget());
else if (IProjectPanelFactory *ipf = qobject_cast<IProjectPanelFactory *>(fac))
panel = ipf->createPanel(project);
Q_ASSERT(panel); Q_ASSERT(panel);
PanelsWidget *panelsWidget = new PanelsWidget(m_centralWidget); PanelsWidget *panelsWidget = new PanelsWidget(m_centralWidget);