forked from qt-creator/qt-creator
AndroidAvdManager: Get rid of no-op call to QtcProcess::terminate()
Calling QtcProcess::terminate() is a task for implicit ProcessReaper. Delete the process instead. Change-Id: I92fe34a18e15ca95f6bab2b7932faeee8b92621d Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
@@ -162,14 +162,6 @@ static CreateAvdInfo createAvdCommand(const AndroidConfig &config, const CreateA
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Kill the running process.
|
|
||||||
if (proc.state() != QProcess::NotRunning) {
|
|
||||||
proc.terminate();
|
|
||||||
if (!proc.waitForFinished(3000))
|
|
||||||
proc.kill();
|
|
||||||
}
|
|
||||||
|
|
||||||
QTC_CHECK(proc.state() == QProcess::NotRunning);
|
|
||||||
result.error = errorOutput;
|
result.error = errorOutput;
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user