feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: rename RunConfiguration::extraApects() to aspects()

Browse Source 
It's the standard way nowaday, nothing 'extra' to it anymore.

Also change to ranged for when using it.

Change-Id: Ic39480e736ba09fdcafc38d5e8d16ee4ec750fdd
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
hjk
2018-09-07 13:55:48 +02:00
parent e7f649a194
commit 6688623b37
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/projectexplorer/runconfiguration.h
View File

@@ -202,7 +202,7 @@ public:
bool fromMap(const QVariantMap &map) override;
QVariantMap toMap() const override;
QList<IRunConfigurationAspect *> extraAspects() const;
const QList<IRunConfigurationAspect *> aspects() const;
IRunConfigurationAspect *extraAspect(Core::Id id) const;
template <typename T> T *extraAspect() const

5
src/plugins/projectexplorer/runsettingspropertiespage.cpp
View File

@@ -528,9 +528,8 @@ QString RunSettingsWidget::uniqueRCName(const QString &name)
void RunSettingsWidget::addRunControlWidgets()
{
foreach (IRunConfigurationAspect *aspect, m_runConfiguration->extraAspects()) {
RunConfigWidget *rcw = aspect->createConfigurationWidget();
if (rcw)
for (IRunConfigurationAspect *aspect : m_runConfiguration->aspects()) {
if (RunConfigWidget *rcw = aspect->createConfigurationWidget())
addSubWidget(rcw);
}
}