feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clenaup handleRunControlFinished.

Browse Source 
handleRunControlFinished was already handled in
ProjectExplorerPlugin::initialize and it just emit updateRunActions
signal. There is no need to call a function just to emit a signal as
long as "connect" can do it for us.

Change-Id: I58e759eb9101b65e6faa117f5157c63f69b18ea9
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
This commit is contained in:
BogDan Vatra
2015-03-22 11:44:50 +02:00
parent ec161a4aa6
commit 669d9ede54
1 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/projectexplorer/projectexplorer.cpp
View File

@@ -288,7 +288,6 @@ public:
void updateWelcomePage();
void handleRunControlFinished();
void runConfigurationConfigurationFinished();
public:
@@ -568,7 +567,7 @@ bool ProjectExplorerPlugin::initialize(const QStringList &arguments, QString *er
connect(dd->m_outputPane, &AppOutputPane::runControlFinished,
this, &ProjectExplorerPlugin::runControlFinished);
connect(dd->m_outputPane, &AppOutputPane::runControlFinished,
dd, &ProjectExplorerPluginPrivate::handleRunControlFinished);
this, &ProjectExplorerPlugin::updateRunActions);
addAutoReleasedObject(new AllProjectsFilter);
addAutoReleasedObject(new CurrentProjectFilter);
@@ -1966,11 +1965,6 @@ void ProjectExplorerPlugin::startRunControl(RunControl *runControl, RunMode runM
dd->startRunControl(runControl, runMode);
}
void ProjectExplorerPluginPrivate::handleRunControlFinished()
{
emit m_instance->updateRunActions();
}
void ProjectExplorerPluginPrivate::startRunControl(RunControl *runControl, RunMode runMode)
{
m_outputPane->createNewOutputWindow(runControl);
@@ -1980,8 +1974,6 @@ void ProjectExplorerPluginPrivate::startRunControl(RunControl *runControl, RunMo
|| ((runMode == DebugRunMode || runMode == DebugRunModeWithBreakOnMain)
&& m_projectExplorerSettings.showDebugOutput);
m_outputPane->setBehaviorOnOutput(runControl, popup ? AppOutputPane::Popup : AppOutputPane::Flash);
QObject::connect(runControl, &RunControl::finished,
this, &ProjectExplorerPluginPrivate::handleRunControlFinished);
runControl->start();
emit m_instance->updateRunActions();
}