Reaper: do not disconnect process before reaping

AbstractProcessStep is relying on signals which breaks with
the disconnect call.

Amends ebae255e49

Fixes: QTCREATORBUG-26271
Change-Id: I16ebaad68352be5c41492e5c4d4fbc3f032e2e39
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

src/plugins/cmakeprojectmanager/cmakeprocess.cpp

@@ -57,8 +57,10 @@ CMakeProcess::CMakeProcess()
 
 CMakeProcess::~CMakeProcess()
 {
-    if (m_process)
+    if (m_process) {
+        m_process->disconnect();
         Core::Reaper::reap(m_process.release());
+    }
 
     m_parser.flush();
 

src/plugins/coreplugin/reaper.cpp

@@ -159,7 +159,6 @@ void reap(QtcProcess *process, int timeoutMs)
 
     process->setStdOutCallback(nullptr);
     process->setStdErrCallback(nullptr);
-    process->disconnect();
 
     QTC_ASSERT(Internal::d, return);