lsp: don't recreate toolbars all the times

Amends 5f8ffd66ff that had a connect-call
at the wrong place. Each time the toolbar needs to be rebuild, it
connects a call to the method changing the toolbar.

Fixes: QTCREATORBUG-32356
Change-Id: Ia40619d2d7a8c19bb5fd0d3fc7a0fbf133bd7c33
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>

src/plugins/qmljseditor/qmljseditor.cpp

@@ -121,6 +121,9 @@ QmlJSEditorWidget::QmlJSEditorWidget()
 {
     m_findReferences = new FindReferences(this);
     setLanguageSettingsId(QmlJSTools::Constants::QML_JS_SETTINGS_ID);
+
+    connect(this, &QmlJSEditorWidget::toolbarOutlineChanged,
+            this, &QmlJSEditorWidget::updateOutline);
 }
 
 void QmlJSEditorWidget::finalizeInitialization()
@@ -581,8 +584,6 @@ void QmlJSEditorWidget::createToolBar()
 
     connect(this, &QmlJSEditorWidget::cursorPositionChanged,
             &m_updateOutlineIndexTimer, QOverload<>::of(&QTimer::start));
-    connect(this, &QmlJSEditorWidget::toolbarOutlineChanged,
-            this, &QmlJSEditorWidget::updateOutline);
 
     setToolbarOutline(m_outlineCombo);
 }