feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Show proper error dialog if adding duplicate property

Browse Source 
Task-number: QDS-7702
Change-Id: I43f07afa95cef75e53bbc0259f6dd21b7c1a5363
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
This commit is contained in:
Thomas Hartmann
2022-09-16 17:21:03 +02:00
parent e936ef2fdb
commit 6b8e2fbd49
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/qmldesigner/components/propertyeditor/dynamicpropertiesproxymodel.cpp
View File

@@ -35,6 +35,7 @@
#include <qmldesignerconstants.h> #include <qmldesignerconstants.h>
#include <qmldesignerplugin.h> #include <qmldesignerplugin.h>
#include <coreplugin/messagebox.h>
#include <utils/qtcassert.h> #include <utils/qtcassert.h>
#include <QScopeGuard> #include <QScopeGuard>
@@ -150,6 +151,12 @@ void DynamicPropertiesProxyModel::createProperty(const QString &name, const QStr
if (selectedNodes.count() == 1) { if (selectedNodes.count() == 1) {
const ModelNode modelNode = selectedNodes.constFirst(); const ModelNode modelNode = selectedNodes.constFirst();
if (modelNode.isValid()) { if (modelNode.isValid()) {
if (modelNode.hasProperty(name.toUtf8())) {
Core::AsynchronousMessageBox::warning(tr("Property already exists"),
tr("Property '%1' already exists")
.arg(name));
return;
}
try { try {
if (Internal::DynamicPropertiesModel::isValueType(typeName)) { if (Internal::DynamicPropertiesModel::isValueType(typeName)) {
QVariant value = Internal::DynamicPropertiesModel::defaultValueForType(typeName); QVariant value = Internal::DynamicPropertiesModel::defaultValueForType(typeName);