feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Fix StringAspect TextEditDisplay

Browse Source 
Remove the unnecessary re-setting of the text edit
content due to the undo => edit => undo => edit
connection.

Fixes: QTCREATORBUG-29688
Change-Id: I7838ed594ae3741df757fa5eb3cdd90506428be3
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Marcus Tillmanns
2023-10-04 14:31:35 +02:00
parent c50f9a9273
commit 6cd2e6de0c
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/libs/utils/aspects.cpp
View File

@@ -1229,14 +1229,19 @@ void StringAspect::addToLayout(LayoutItem &parent)
&QTextEdit::setPlaceholderText);
connect(textEditDisplay, &QTextEdit::textChanged, this, [this, textEditDisplay]() {
d->undoable.set(undoStack(), textEditDisplay->toPlainText());
handleGuiChanged();
if (textEditDisplay->toPlainText() != d->undoable.get()) {
d->undoable.set(undoStack(), textEditDisplay->toPlainText());
handleGuiChanged();
}
});
connect(&d->undoable.m_signal,
&UndoSignaller::changed,
textEditDisplay,
[this, textEditDisplay] { textEditDisplay->setText(d->undoable.get()); });
[this, textEditDisplay] {
if (textEditDisplay->toPlainText() != d->undoable.get())
textEditDisplay->setText(d->undoable.get());
});
break;
}
case LabelDisplay: {